You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/20 07:00:08 UTC

[GitHub] [incubator-nuttx] yamt commented on pull request #2347: Enable format check for syslog

yamt commented on pull request #2347:
URL: https://github.com/apache/incubator-nuttx/pull/2347#issuecomment-730949096


   > @yamt we need add sysloglike to _none too, so the more mismatch can be exposured:
   > https://github.com/apache/incubator-nuttx/blob/master/include/debug.h#L107-L111
   
   _none is a macro. and i don't think the attribute can be added to macros.
   
   i guess it isn't acceptable to make _none a function as the idea of the macro is to eliminate it at compile time.
   
   an inline function might be a solution. but i suspect it's controversial. i'm not sure if it can be optimized out cleanly as a macro either.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org