You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2007/05/03 20:29:15 UTC
[jira] Commented: (GERONIMO-3137) Servlets must rollback
uncommitted transaction when the service method exits
[ https://issues.apache.org/jira/browse/GERONIMO-3137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493446 ]
David Jencks commented on GERONIMO-3137:
----------------------------------------
Untested impl for jetty in rev 534953.
> Servlets must rollback uncommitted transaction when the service method exits
> ----------------------------------------------------------------------------
>
> Key: GERONIMO-3137
> URL: https://issues.apache.org/jira/browse/GERONIMO-3137
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: web
> Reporter: Dain Sundstrom
> Assigned To: David Jencks
>
> Servlets must rollback uncommitted transaction when the service method exits. The servlet should check for a tx on entry and if one is not present on entry but there is one on exit, it should be rolled back.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (GERONIMO-3137) Servlets must rollback uncommitted transaction when the service method exits
Posted by Dain Sundstrom <da...@iq80.com>.
On May 4, 2007, at 3:00 AM, Daniel Alheiros wrote:
> Do you think it could be interesting logging this in a WARN level
> to make
> the application developer to fix it? I believe it will only happen
> caused by
> bad code, so...
The rule appears to be:
if servlet started a UT and it is marked rollback only,
rollback the ut on servlet exit
else if the servlet is the original web request (not a dispatch) and
there is an open tx
rollback the ut on servlet exit
otherwise
leave the transaction open
The rule is a bit strange, but that is the way they seem to want it.
Anyway, the first condition can be caused by an application exception
where the code does ut.setRollbackOnly. The second condition is a
programming error and as you suggest, should be logged at WARN.
-dain
Re: [jira] Commented: (GERONIMO-3137) Servlets must rollback
uncommitted transaction when the service method exits
Posted by Daniel Alheiros <Da...@bbc.co.uk>.
Do you think it could be interesting logging this in a WARN level to make
the application developer to fix it? I believe it will only happen caused by
bad code, so...
Regards,
Daniel
On 3/5/07 19:29, "David Jencks (JIRA)" <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/GERONIMO-3137?page=com.atlassian.jira.pl
> ugin.system.issuetabpanels:comment-tabpanel#action_12493446 ]
>
> David Jencks commented on GERONIMO-3137:
> ----------------------------------------
>
> Untested impl for jetty in rev 534953.
>
>> Servlets must rollback uncommitted transaction when the service method exits
>> ----------------------------------------------------------------------------
>>
>> Key: GERONIMO-3137
>> URL: https://issues.apache.org/jira/browse/GERONIMO-3137
>> Project: Geronimo
>> Issue Type: Bug
>> Security Level: public(Regular issues)
>> Components: web
>> Reporter: Dain Sundstrom
>> Assigned To: David Jencks
>>
>> Servlets must rollback uncommitted transaction when the service method exits.
>> The servlet should check for a tx on entry and if one is not present on entry
>> but there is one on exit, it should be rolled back.
http://www.bbc.co.uk/
This e-mail (and any attachments) is confidential and may contain personal views which are not the views of the BBC unless specifically stated.
If you have received it in error, please delete it from your system.
Do not use, copy or disclose the information in any way nor act in reliance on it and notify the sender immediately.
Please note that the BBC monitors e-mails sent or received.
Further communication will signify your consent to this.