You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Unico Hommes (Created) (JIRA)" <ji...@apache.org> on 2012/01/13 14:04:44 UTC
[jira] [Created] (JCR-3207) Info map of NODE_MOVED event on node
reordering is not according to spec
Info map of NODE_MOVED event on node reordering is not according to spec
------------------------------------------------------------------------
Key: JCR-3207
URL: https://issues.apache.org/jira/browse/JCR-3207
Project: Jackrabbit Content Repository
Issue Type: Bug
Affects Versions: 2.3.5, 2.2.10
Reporter: Unico Hommes
According to JSR-283 "If the method that caused the NODE_MOVE event was a Node.orderBefore then the returned Map has keys srcChildRelPath and destChildRelPath with values corresponding to the parameters passed to the orderBefore method, as specified in the Javadoc." As the attached patch for the ReorderTest test case shows this is not the way jackrabbit behaves. Instead it looks like the value of the srcChildRelPath entry in the info map is really the destChildRelPath and destChildRelPath info entry seems to always be null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3207) Info map of NODE_MOVED event on node
reordering is not according to spec
Posted by "Julian Reschke (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185673#comment-13185673 ]
Julian Reschke commented on JCR-3207:
-------------------------------------
I can confirm that there's a compliance issue here. Unfortunately it's non-trivial to fix.
Events are generated based on the change information on NodeState. NodeState has the new ordering of the child elements, but doesn't how the new ordering was obtained; therefore, given a node with children a and b the event info would be the same for:
orderBefore("b", "a")
and
orderBefore("a", null)
Furthemore, in order to compute the event EventStateCollection compares with the previous ordering. This is likely to fail for any save() operation that contains more than a single operation causing the ordering to change.
Feedback appreciated.
> Info map of NODE_MOVED event on node reordering is not according to spec
> ------------------------------------------------------------------------
>
> Key: JCR-3207
> URL: https://issues.apache.org/jira/browse/JCR-3207
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Affects Versions: 2.2.10, 2.3.5
> Reporter: Unico Hommes
> Assignee: Julian Reschke
> Attachments: reordertest.patch
>
>
> According to JSR-283 "If the method that caused the NODE_MOVE event was a Node.orderBefore then the returned Map has keys srcChildRelPath and destChildRelPath with values corresponding to the parameters passed to the orderBefore method, as specified in the Javadoc." As the attached patch for the ReorderTest test case shows this is not the way jackrabbit behaves. Instead it looks like the value of the srcChildRelPath entry in the info map is really the destChildRelPath and destChildRelPath info entry seems to always be null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3207) Info map of NODE_MOVED event on node
reordering is not according to spec
Posted by "Julian Reschke (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke updated JCR-3207:
--------------------------------
Component/s: observation
jackrabbit-core
> Info map of NODE_MOVED event on node reordering is not according to spec
> ------------------------------------------------------------------------
>
> Key: JCR-3207
> URL: https://issues.apache.org/jira/browse/JCR-3207
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core, observation
> Affects Versions: 2.2.10, 2.3.5
> Reporter: Unico Hommes
> Assignee: Julian Reschke
> Attachments: reordertest.patch
>
>
> According to JSR-283 "If the method that caused the NODE_MOVE event was a Node.orderBefore then the returned Map has keys srcChildRelPath and destChildRelPath with values corresponding to the parameters passed to the orderBefore method, as specified in the Javadoc." As the attached patch for the ReorderTest test case shows this is not the way jackrabbit behaves. Instead it looks like the value of the srcChildRelPath entry in the info map is really the destChildRelPath and destChildRelPath info entry seems to always be null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3207) Info map of NODE_MOVED event on node
reordering is not according to spec
Posted by "Unico Hommes (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Unico Hommes updated JCR-3207:
------------------------------
Attachment: reordertest.patch
Patch for ReorderTest.java in jackrabbit-core. Apply by cd'ing to jackrabbit-core and executing the command $patch -u -p0 < reordertest.patch
> Info map of NODE_MOVED event on node reordering is not according to spec
> ------------------------------------------------------------------------
>
> Key: JCR-3207
> URL: https://issues.apache.org/jira/browse/JCR-3207
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Affects Versions: 2.2.10, 2.3.5
> Reporter: Unico Hommes
> Attachments: reordertest.patch
>
>
> According to JSR-283 "If the method that caused the NODE_MOVE event was a Node.orderBefore then the returned Map has keys srcChildRelPath and destChildRelPath with values corresponding to the parameters passed to the orderBefore method, as specified in the Javadoc." As the attached patch for the ReorderTest test case shows this is not the way jackrabbit behaves. Instead it looks like the value of the srcChildRelPath entry in the info map is really the destChildRelPath and destChildRelPath info entry seems to always be null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (JCR-3207) Info map of NODE_MOVED event on node
reordering is not according to spec
Posted by "Julian Reschke (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke reassigned JCR-3207:
-----------------------------------
Assignee: Julian Reschke
> Info map of NODE_MOVED event on node reordering is not according to spec
> ------------------------------------------------------------------------
>
> Key: JCR-3207
> URL: https://issues.apache.org/jira/browse/JCR-3207
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Affects Versions: 2.2.10, 2.3.5
> Reporter: Unico Hommes
> Assignee: Julian Reschke
> Attachments: reordertest.patch
>
>
> According to JSR-283 "If the method that caused the NODE_MOVE event was a Node.orderBefore then the returned Map has keys srcChildRelPath and destChildRelPath with values corresponding to the parameters passed to the orderBefore method, as specified in the Javadoc." As the attached patch for the ReorderTest test case shows this is not the way jackrabbit behaves. Instead it looks like the value of the srcChildRelPath entry in the info map is really the destChildRelPath and destChildRelPath info entry seems to always be null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira