[GitHub] [lucene-solr] megancarey commented on a change in pull request #1117: SOLR-13101: ant precommit fixes

[GitBox <gi...@apache.org>]

megancarey commented on a change in pull request #1117: SOLR-13101: ant precommit fixes
URL: https://github.com/apache/lucene-solr/pull/1117#discussion_r361037691
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/store/blob/client/LocalStorageClient.java
 ##########
 @@ -97,7 +117,7 @@ public void pushCoreMetadata(String sharedStoreName, String blobCoreMetadataName
 
       // Writing to the file assumed atomic, the file cannot be observed midway. Might not hold here but should be the case
       // with a real S3 implementation.
-      try (PrintWriter out = new PrintWriter(blobMetadataFile)){
+      try (PrintWriter out = new PrintWriter(blobMetadataFile, StandardCharsets.UTF_8.name())){
 
 Review comment:
   @andyvuong I've made an assumption here that all of our blob files are UTF-8 encoded, is that a valid assumption? We need to specify a charset to decode in several places

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org