You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "John Sirois (Created) (JIRA)" <ji...@apache.org> on 2011/10/26 02:48:32 UTC

[jira] [Created] (MESOS-45) Document semantics and state transitions in mesos user-pluggable interfaces

Document semantics and state transitions in mesos user-pluggable interfaces
---------------------------------------------------------------------------

                 Key: MESOS-45
                 URL: https://issues.apache.org/jira/browse/MESOS-45
             Project: Mesos
          Issue Type: Improvement
          Components: c++-api, java-api, python-api
            Reporter: John Sirois


In particular, scheduler and executor lifecycle and re-entrancy requirements should be documented well either centrally, in a HOW-TO/spec or better, additionally or solely in binding interfaces in the supported languages (cpp, java, python).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [jira] [Commented] (MESOS-45) Document semantics and state transitions in mesos user-pluggable interfaces

Posted by Benjamin Hindman <be...@eecs.berkeley.edu>.
http://www.apache.org/foundation/mailinglists.html

The mesos-user@incubator.apache.org should be less noisy and contain
helpful information about releases, etc.



On Wed, Jan 25, 2012 at 5:21 PM, Anthony Kline
<ak...@rivierapartners.com>wrote:

> How do I unsubscribe from this list?
>
>
> -----Original Message-----
> From: jiraposter@reviews.apache.org (Commented) (JIRA) [mailto:
> jira@apache.org]
> Sent: Wednesday, January 25, 2012 9:21 AM
> To: mesos-dev@incubator.apache.org
> Subject: [jira] [Commented] (MESOS-45) Document semantics and state
> transitions in mesos user-pluggable interfaces
>
>
>    [
> https://issues.apache.org/jira/browse/MESOS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193135#comment-13193135]
>
> jiraposter@reviews.apache.org commented on MESOS-45:
> ----------------------------------------------------
>
>
>
> bq.  On 2012-01-25 02:53:08, John Sirois wrote:
> bq.  >
>
> Thanks John, submitting.
>
>
> bq.  On 2012-01-25 02:53:08, John Sirois wrote:
> bq.  > src/java/src/org/apache/mesos/Executor.java, line 33 bq.  > <
> https://reviews.apache.org/r/3442/diff/1-2/?file=67449#file67449line33>
> bq.  >
> bq.  >     syntax is one of:
> bq.  >     {@link #[localmethod]}
> bq.  >     {@link [otherclass]#[method]}
>
> Great, done.
>
>
> bq.  On 2012-01-25 02:53:08, John Sirois wrote:
> bq.  > src/java/src/org/apache/mesos/MesosSchedulerDriver.java, line 73
> bq.  > <
> https://reviews.apache.org/r/3442/diff/1-2/?file=67452#file67452line73>
> bq.  >
> bq.  >     fix message
>
> Done.
>
>
> - Benjamin
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3442/#review4577
> -----------------------------------------------------------
>
>
> On 2012-01-25 01:55:49, Benjamin Hindman wrote:
> bq.
> bq.  -----------------------------------------------------------
> bq.  This is an automatically generated e-mail. To reply, visit:
> bq.  https://reviews.apache.org/r/3442/
> bq.  -----------------------------------------------------------
> bq.
> bq.  (Updated 2012-01-25 01:55:49)
> bq.
> bq.
> bq.  Review request for mesos, Andy Konwinski, Charles Reiss, Matei
> Zaharia, John Sirois, and Vinod Kone.
> bq.
> bq.
> bq.  Summary
> bq.  -------
> bq.
> bq.  Provides initial documentation to the public interfaces (thanks to
> Vinod Kone for pairing with me on this).
> bq.
> bq.
> bq.  This addresses bug MESOS-45.
> bq.      https://issues.apache.org/jira/browse/MESOS-45
> bq.
> bq.
> bq.  Diffs
> bq.  -----
> bq.
> bq.    include/mesos/executor.hpp 68f5bda
> bq.    include/mesos/mesos.proto 3c3f632
> bq.    include/mesos/scheduler.hpp 93dda98
> bq.    src/java/src/org/apache/mesos/Executor.java ea2b1a2
> bq.    src/java/src/org/apache/mesos/ExecutorDriver.java 66c2563
> bq.    src/java/src/org/apache/mesos/MesosExecutorDriver.java 2887f7b
> bq.    src/java/src/org/apache/mesos/MesosSchedulerDriver.java 90a193b
> bq.    src/java/src/org/apache/mesos/Scheduler.java c429a95
> bq.    src/java/src/org/apache/mesos/SchedulerDriver.java d31c9d1
> bq.    src/python/src/mesos.py d2088da
> bq.
> bq.  Diff: https://reviews.apache.org/r/3442/diff
> bq.
> bq.
> bq.  Testing
> bq.  -------
> bq.
> bq.
> bq.  Thanks,
> bq.
> bq.  Benjamin
> bq.
> bq.
>
>
>
> > Document semantics and state transitions in mesos user-pluggable
> > interfaces
> > ----------------------------------------------------------------------
> > -----
> >
> >                 Key: MESOS-45
> >                 URL: https://issues.apache.org/jira/browse/MESOS-45
> >             Project: Mesos
> >          Issue Type: Improvement
> >          Components: c++-api, java-api, python-api
> >            Reporter: John Sirois
> >
> > In particular, scheduler and executor lifecycle and re-entrancy
> requirements should be documented well either centrally, in a HOW-TO/spec
> or better, additionally or solely in binding interfaces in the supported
> languages (cpp, java, python).
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>

RE: [jira] [Commented] (MESOS-45) Document semantics and state transitions in mesos user-pluggable interfaces

Posted by Anthony Kline <ak...@rivierapartners.com>.
How do I unsubscribe from this list? 


-----Original Message-----
From: jiraposter@reviews.apache.org (Commented) (JIRA) [mailto:jira@apache.org] 
Sent: Wednesday, January 25, 2012 9:21 AM
To: mesos-dev@incubator.apache.org
Subject: [jira] [Commented] (MESOS-45) Document semantics and state transitions in mesos user-pluggable interfaces


    [ https://issues.apache.org/jira/browse/MESOS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193135#comment-13193135 ] 

jiraposter@reviews.apache.org commented on MESOS-45:
----------------------------------------------------



bq.  On 2012-01-25 02:53:08, John Sirois wrote:
bq.  >

Thanks John, submitting.


bq.  On 2012-01-25 02:53:08, John Sirois wrote:
bq.  > src/java/src/org/apache/mesos/Executor.java, line 33 bq.  > <https://reviews.apache.org/r/3442/diff/1-2/?file=67449#file67449line33>
bq.  >
bq.  >     syntax is one of:
bq.  >     {@link #[localmethod]}
bq.  >     {@link [otherclass]#[method]}

Great, done.


bq.  On 2012-01-25 02:53:08, John Sirois wrote:
bq.  > src/java/src/org/apache/mesos/MesosSchedulerDriver.java, line 73 bq.  > <https://reviews.apache.org/r/3442/diff/1-2/?file=67452#file67452line73>
bq.  >
bq.  >     fix message

Done.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3442/#review4577
-----------------------------------------------------------


On 2012-01-25 01:55:49, Benjamin Hindman wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3442/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-25 01:55:49)
bq.  
bq.  
bq.  Review request for mesos, Andy Konwinski, Charles Reiss, Matei Zaharia, John Sirois, and Vinod Kone.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Provides initial documentation to the public interfaces (thanks to Vinod Kone for pairing with me on this).
bq.  
bq.  
bq.  This addresses bug MESOS-45.
bq.      https://issues.apache.org/jira/browse/MESOS-45
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    include/mesos/executor.hpp 68f5bda 
bq.    include/mesos/mesos.proto 3c3f632 
bq.    include/mesos/scheduler.hpp 93dda98 
bq.    src/java/src/org/apache/mesos/Executor.java ea2b1a2 
bq.    src/java/src/org/apache/mesos/ExecutorDriver.java 66c2563 
bq.    src/java/src/org/apache/mesos/MesosExecutorDriver.java 2887f7b 
bq.    src/java/src/org/apache/mesos/MesosSchedulerDriver.java 90a193b 
bq.    src/java/src/org/apache/mesos/Scheduler.java c429a95 
bq.    src/java/src/org/apache/mesos/SchedulerDriver.java d31c9d1 
bq.    src/python/src/mesos.py d2088da 
bq.  
bq.  Diff: https://reviews.apache.org/r/3442/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Benjamin
bq.  
bq.


                
> Document semantics and state transitions in mesos user-pluggable 
> interfaces
> ----------------------------------------------------------------------
> -----
>
>                 Key: MESOS-45
>                 URL: https://issues.apache.org/jira/browse/MESOS-45
>             Project: Mesos
>          Issue Type: Improvement
>          Components: c++-api, java-api, python-api
>            Reporter: John Sirois
>
> In particular, scheduler and executor lifecycle and re-entrancy requirements should be documented well either centrally, in a HOW-TO/spec or better, additionally or solely in binding interfaces in the supported languages (cpp, java, python).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MESOS-45) Document semantics and state transitions in mesos user-pluggable interfaces

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192786#comment-13192786 ] 

jiraposter@reviews.apache.org commented on MESOS-45:
----------------------------------------------------



bq.  On 2012-01-10 14:26:24, John Sirois wrote:
bq.  > This is very, very helpful.  Thanks.
bq.  > I focused on the javadoc but threw in java api nits as well (from the perspective of a mesos library maintainer).
bq.  > The javadoc should really follow http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html,  but the most glaring omissions are @parameter,@return docs.

Yes, I'd love to see these too. Perhaps this will get done in the second round, or could get contributed by someone else.


bq.  On 2012-01-10 14:26:24, John Sirois wrote:
bq.  > src/java/src/org/apache/mesos/Scheduler.java, line 39
bq.  > <https://reviews.apache.org/r/3442/diff/1/?file=67453#file67453line39>
bq.  >
bq.  >     The driver parameter in all methods other than register deserves explanation - must I use the it in the scope of the callback or is it always the same as the regsitered or ...?

Done.


bq.  On 2012-01-10 14:26:24, John Sirois wrote:
bq.  > src/java/src/org/apache/mesos/SchedulerDriver.java, line 38
bq.  > <https://reviews.apache.org/r/3442/diff/1/?file=67454#file67454line38>
bq.  >
bq.  >     s/public // - these are redundant for interface members

Done.


bq.  On 2012-01-10 14:26:24, John Sirois wrote:
bq.  > src/java/src/org/apache/mesos/SchedulerDriver.java, line 43
bq.  > <https://reviews.apache.org/r/3442/diff/1/?file=67454#file67454line43>
bq.  >
bq.  >     how does this stop relate to the overload?  failover=true or false?

Updated the comment. Thanks.


bq.  On 2012-01-10 14:26:24, John Sirois wrote:
bq.  > src/java/src/org/apache/mesos/SchedulerDriver.java, line 85
bq.  > <https://reviews.apache.org/r/3442/diff/1/?file=67454#file67454line85>
bq.  >
bq.  >     Is Iterable enough for the impl? - if so prefer it.

This is a much more invasive change (updates to the JNI bindings are required). If you feel highly about this please create a JIRA, and feel free to submit a patch too!. ;)


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3442/#review4294
-----------------------------------------------------------


On 2012-01-10 06:48:03, Benjamin Hindman wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3442/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-10 06:48:03)
bq.  
bq.  
bq.  Review request for mesos, Andy Konwinski, Charles Reiss, Matei Zaharia, John Sirois, and Vinod Kone.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Provides initial documentation to the public interfaces (thanks to Vinod Kone for pairing with me on this).
bq.  
bq.  
bq.  This addresses bug MESOS-45.
bq.      https://issues.apache.org/jira/browse/MESOS-45
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    include/mesos/executor.hpp d883f1a 
bq.    include/mesos/mesos.proto 77a9067 
bq.    include/mesos/scheduler.hpp 93dda98 
bq.    src/java/src/org/apache/mesos/Executor.java 5ad8cee 
bq.    src/java/src/org/apache/mesos/ExecutorDriver.java be01d21 
bq.    src/java/src/org/apache/mesos/MesosExecutorDriver.java 399c8b8 
bq.    src/java/src/org/apache/mesos/MesosSchedulerDriver.java 04809a6 
bq.    src/java/src/org/apache/mesos/Scheduler.java 63a06fe 
bq.    src/java/src/org/apache/mesos/SchedulerDriver.java 23a246c 
bq.    src/python/src/mesos.py 5fc60e2 
bq.  
bq.  Diff: https://reviews.apache.org/r/3442/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Benjamin
bq.  
bq.


                
> Document semantics and state transitions in mesos user-pluggable interfaces
> ---------------------------------------------------------------------------
>
>                 Key: MESOS-45
>                 URL: https://issues.apache.org/jira/browse/MESOS-45
>             Project: Mesos
>          Issue Type: Improvement
>          Components: c++-api, java-api, python-api
>            Reporter: John Sirois
>
> In particular, scheduler and executor lifecycle and re-entrancy requirements should be documented well either centrally, in a HOW-TO/spec or better, additionally or solely in binding interfaces in the supported languages (cpp, java, python).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MESOS-45) Document semantics and state transitions in mesos user-pluggable interfaces

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192787#comment-13192787 ] 

jiraposter@reviews.apache.org commented on MESOS-45:
----------------------------------------------------



bq.  On 2012-01-10 18:15:45, Brian Wickman wrote:
bq.  > src/python/src/mesos.py, line 24
bq.  > <https://reviews.apache.org/r/3442/diff/1/?file=67455#file67455line24>
bq.  >
bq.  >     This should be pydoc.

I agree, want to contribute it!?


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3442/#review4299
-----------------------------------------------------------


On 2012-01-25 01:55:49, Benjamin Hindman wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3442/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-25 01:55:49)
bq.  
bq.  
bq.  Review request for mesos, Andy Konwinski, Charles Reiss, Matei Zaharia, John Sirois, and Vinod Kone.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Provides initial documentation to the public interfaces (thanks to Vinod Kone for pairing with me on this).
bq.  
bq.  
bq.  This addresses bug MESOS-45.
bq.      https://issues.apache.org/jira/browse/MESOS-45
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    include/mesos/executor.hpp 68f5bda 
bq.    include/mesos/mesos.proto 3c3f632 
bq.    include/mesos/scheduler.hpp 93dda98 
bq.    src/java/src/org/apache/mesos/Executor.java ea2b1a2 
bq.    src/java/src/org/apache/mesos/ExecutorDriver.java 66c2563 
bq.    src/java/src/org/apache/mesos/MesosExecutorDriver.java 2887f7b 
bq.    src/java/src/org/apache/mesos/MesosSchedulerDriver.java 90a193b 
bq.    src/java/src/org/apache/mesos/Scheduler.java c429a95 
bq.    src/java/src/org/apache/mesos/SchedulerDriver.java d31c9d1 
bq.    src/python/src/mesos.py d2088da 
bq.  
bq.  Diff: https://reviews.apache.org/r/3442/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Benjamin
bq.  
bq.


                
> Document semantics and state transitions in mesos user-pluggable interfaces
> ---------------------------------------------------------------------------
>
>                 Key: MESOS-45
>                 URL: https://issues.apache.org/jira/browse/MESOS-45
>             Project: Mesos
>          Issue Type: Improvement
>          Components: c++-api, java-api, python-api
>            Reporter: John Sirois
>
> In particular, scheduler and executor lifecycle and re-entrancy requirements should be documented well either centrally, in a HOW-TO/spec or better, additionally or solely in binding interfaces in the supported languages (cpp, java, python).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MESOS-45) Document semantics and state transitions in mesos user-pluggable interfaces

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183376#comment-13183376 ] 

jiraposter@reviews.apache.org commented on MESOS-45:
----------------------------------------------------



bq.  On 2012-01-10 14:26:24, John Sirois wrote:
bq.  > src/java/src/org/apache/mesos/Scheduler.java, line 57
bq.  > <https://reviews.apache.org/r/3442/diff/1/?file=67453#file67453line57>
bq.  >
bq.  >     There appears to be no need fo indexed access - Collection if you want to provide size, but it seems Iterable is fine here.

Going over the offers in the same order multiple times is useful in complex schedulers -- for example, we do it in Spark. I suggest leaving it this way, unless you want everyone to copy their Collection to a list. I can't anticipate a scenario when it would be more efficient to use an unordered collection here, and in other languages, such as Python, the collection will be ordered anyway.


- Matei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3442/#review4294
-----------------------------------------------------------


On 2012-01-10 06:48:03, Benjamin Hindman wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3442/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-10 06:48:03)
bq.  
bq.  
bq.  Review request for mesos, Andy Konwinski, Charles Reiss, Matei Zaharia, John Sirois, and Vinod Kone.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Provides initial documentation to the public interfaces (thanks to Vinod Kone for pairing with me on this).
bq.  
bq.  
bq.  This addresses bug MESOS-45.
bq.      https://issues.apache.org/jira/browse/MESOS-45
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    include/mesos/executor.hpp d883f1a 
bq.    include/mesos/mesos.proto 77a9067 
bq.    include/mesos/scheduler.hpp 93dda98 
bq.    src/java/src/org/apache/mesos/Executor.java 5ad8cee 
bq.    src/java/src/org/apache/mesos/ExecutorDriver.java be01d21 
bq.    src/java/src/org/apache/mesos/MesosExecutorDriver.java 399c8b8 
bq.    src/java/src/org/apache/mesos/MesosSchedulerDriver.java 04809a6 
bq.    src/java/src/org/apache/mesos/Scheduler.java 63a06fe 
bq.    src/java/src/org/apache/mesos/SchedulerDriver.java 23a246c 
bq.    src/python/src/mesos.py 5fc60e2 
bq.  
bq.  Diff: https://reviews.apache.org/r/3442/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Benjamin
bq.  
bq.


                
> Document semantics and state transitions in mesos user-pluggable interfaces
> ---------------------------------------------------------------------------
>
>                 Key: MESOS-45
>                 URL: https://issues.apache.org/jira/browse/MESOS-45
>             Project: Mesos
>          Issue Type: Improvement
>          Components: c++-api, java-api, python-api
>            Reporter: John Sirois
>
> In particular, scheduler and executor lifecycle and re-entrancy requirements should be documented well either centrally, in a HOW-TO/spec or better, additionally or solely in binding interfaces in the supported languages (cpp, java, python).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MESOS-45) Document semantics and state transitions in mesos user-pluggable interfaces

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193134#comment-13193134 ] 

jiraposter@reviews.apache.org commented on MESOS-45:
----------------------------------------------------



bq.  On 2012-01-25 03:01:51, Vinod Kone wrote:
bq.  >

Thanks, submitting.


bq.  On 2012-01-25 03:01:51, Vinod Kone wrote:
bq.  > include/mesos/mesos.proto, lines 314-316
bq.  > <https://reviews.apache.org/r/3442/diff/1-2/?file=67447#file67447line314>
bq.  >
bq.  >     kill ws

Done.


bq.  On 2012-01-25 03:01:51, Vinod Kone wrote:
bq.  > src/java/src/org/apache/mesos/ExecutorDriver.java, line 43
bq.  > <https://reviews.apache.org/r/3442/diff/1-2/?file=67450#file67450line43>
bq.  >
bq.  >     kill ws

Done.


bq.  On 2012-01-25 03:01:51, Vinod Kone wrote:
bq.  > src/java/src/org/apache/mesos/SchedulerDriver.java, line 44
bq.  > <https://reviews.apache.org/r/3442/diff/1-2/?file=67454#file67454line44>
bq.  >
bq.  >     kill ws

Done.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3442/#review4579
-----------------------------------------------------------


On 2012-01-25 01:55:49, Benjamin Hindman wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3442/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-25 01:55:49)
bq.  
bq.  
bq.  Review request for mesos, Andy Konwinski, Charles Reiss, Matei Zaharia, John Sirois, and Vinod Kone.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Provides initial documentation to the public interfaces (thanks to Vinod Kone for pairing with me on this).
bq.  
bq.  
bq.  This addresses bug MESOS-45.
bq.      https://issues.apache.org/jira/browse/MESOS-45
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    include/mesos/executor.hpp 68f5bda 
bq.    include/mesos/mesos.proto 3c3f632 
bq.    include/mesos/scheduler.hpp 93dda98 
bq.    src/java/src/org/apache/mesos/Executor.java ea2b1a2 
bq.    src/java/src/org/apache/mesos/ExecutorDriver.java 66c2563 
bq.    src/java/src/org/apache/mesos/MesosExecutorDriver.java 2887f7b 
bq.    src/java/src/org/apache/mesos/MesosSchedulerDriver.java 90a193b 
bq.    src/java/src/org/apache/mesos/Scheduler.java c429a95 
bq.    src/java/src/org/apache/mesos/SchedulerDriver.java d31c9d1 
bq.    src/python/src/mesos.py d2088da 
bq.  
bq.  Diff: https://reviews.apache.org/r/3442/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Benjamin
bq.  
bq.


                
> Document semantics and state transitions in mesos user-pluggable interfaces
> ---------------------------------------------------------------------------
>
>                 Key: MESOS-45
>                 URL: https://issues.apache.org/jira/browse/MESOS-45
>             Project: Mesos
>          Issue Type: Improvement
>          Components: c++-api, java-api, python-api
>            Reporter: John Sirois
>
> In particular, scheduler and executor lifecycle and re-entrancy requirements should be documented well either centrally, in a HOW-TO/spec or better, additionally or solely in binding interfaces in the supported languages (cpp, java, python).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MESOS-45) Document semantics and state transitions in mesos user-pluggable interfaces

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183500#comment-13183500 ] 

jiraposter@reviews.apache.org commented on MESOS-45:
----------------------------------------------------



bq.  On 2012-01-10 14:26:24, John Sirois wrote:
bq.  > src/java/src/org/apache/mesos/Scheduler.java, line 57
bq.  > <https://reviews.apache.org/r/3442/diff/1/?file=67453#file67453line57>
bq.  >
bq.  >     There appears to be no need fo indexed access - Collection if you want to provide size, but it seems Iterable is fine here.
bq.  
bq.  Matei Zaharia wrote:
bq.      Going over the offers in the same order multiple times is useful in complex schedulers -- for example, we do it in Spark. I suggest leaving it this way, unless you want everyone to copy their Collection to a list. I can't anticipate a scenario when it would be more efficient to use an unordered collection here, and in other languages, such as Python, the collection will be ordered anyway.
bq.  
bq.  John Sirois wrote:
bq.      The comment wasn't derived from efficiency concerns - a List could still be passed since its Iterable.  I was suggesting this change as an api maintainer - Iterable gives you more freedom going forward to change implementation without breaking clients and your clients still get a sequence of offers they can repeatedly iterate over.  You might add extra javadoc that says the iterators are guaranteed to be stable wrt each other, but this is implicit for all Iterables I've encountered in java land.
bq.  
bq.  Matei Zaharia wrote:
bq.      I realize that the comment isn't from efficiency concerns, but I'm just saying that I can't imagine a case where the implementation would change in a way that prevents meeting the List interface. Just to be clear, the code I'm talking about doesn't simply want to iterate over the list multiple times -- it wants to know the size of the list and keep some data about each machine offered, and it does use indexes into it. For example, here's a common thing to do: you have a list of tasks you want to launch and a list of machines offered, and you want to spread your tasks across the machines in a round-robin manner as long as they have enough resources. You can do something like this:
bq.      
bq.      memoryLeft = // int array initialized to the memory on each machine
bq.      cpusLeft = // int array initialized to the CPUs on each machine
bq.      while (tasksToLaunch > 0) {
bq.        for (i = 0 to offers.size) {
bq.          if (memoryLeft[i] >= taskMemory && cpusLeft[i] >= taskCpus) {
bq.            launch a task on machine i
bq.            decrease memoryLeft[i] and cpusLeft[i]
bq.          }
bq.        }
bq.      }
bq.      
bq.      Basically, by not providing a List, you're losing some usability without gaining much maintainability. I agree you shouldn't be providing an array or something, but giving a less convenient collection type for something that is already an ordered collection in other languages seems overly picky.

SGTM -  I still don't get the need for an index since the slot an offer is in in the List has no mesos meaning afaict, but I can buy size.  And I agree with your point that List is likely not too restrictive - I just tend to be _very_ defensive with exposed api types.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3442/#review4294
-----------------------------------------------------------


On 2012-01-10 06:48:03, Benjamin Hindman wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3442/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-10 06:48:03)
bq.  
bq.  
bq.  Review request for mesos, Andy Konwinski, Charles Reiss, Matei Zaharia, John Sirois, and Vinod Kone.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Provides initial documentation to the public interfaces (thanks to Vinod Kone for pairing with me on this).
bq.  
bq.  
bq.  This addresses bug MESOS-45.
bq.      https://issues.apache.org/jira/browse/MESOS-45
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    include/mesos/executor.hpp d883f1a 
bq.    include/mesos/mesos.proto 77a9067 
bq.    include/mesos/scheduler.hpp 93dda98 
bq.    src/java/src/org/apache/mesos/Executor.java 5ad8cee 
bq.    src/java/src/org/apache/mesos/ExecutorDriver.java be01d21 
bq.    src/java/src/org/apache/mesos/MesosExecutorDriver.java 399c8b8 
bq.    src/java/src/org/apache/mesos/MesosSchedulerDriver.java 04809a6 
bq.    src/java/src/org/apache/mesos/Scheduler.java 63a06fe 
bq.    src/java/src/org/apache/mesos/SchedulerDriver.java 23a246c 
bq.    src/python/src/mesos.py 5fc60e2 
bq.  
bq.  Diff: https://reviews.apache.org/r/3442/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Benjamin
bq.  
bq.


                
> Document semantics and state transitions in mesos user-pluggable interfaces
> ---------------------------------------------------------------------------
>
>                 Key: MESOS-45
>                 URL: https://issues.apache.org/jira/browse/MESOS-45
>             Project: Mesos
>          Issue Type: Improvement
>          Components: c++-api, java-api, python-api
>            Reporter: John Sirois
>
> In particular, scheduler and executor lifecycle and re-entrancy requirements should be documented well either centrally, in a HOW-TO/spec or better, additionally or solely in binding interfaces in the supported languages (cpp, java, python).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MESOS-45) Document semantics and state transitions in mesos user-pluggable interfaces

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183439#comment-13183439 ] 

jiraposter@reviews.apache.org commented on MESOS-45:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3442/#review4299
-----------------------------------------------------------



src/python/src/mesos.py
<https://reviews.apache.org/r/3442/#comment9683>

    This should be pydoc.



src/python/src/mesos.py
<https://reviews.apache.org/r/3442/#comment9684>

    Ditto.



src/python/src/mesos.py
<https://reviews.apache.org/r/3442/#comment9685>

    Ditto



src/python/src/mesos.py
<https://reviews.apache.org/r/3442/#comment9686>

    Ditto


- Brian


On 2012-01-10 06:48:03, Benjamin Hindman wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3442/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-10 06:48:03)
bq.  
bq.  
bq.  Review request for mesos, Andy Konwinski, Charles Reiss, Matei Zaharia, John Sirois, and Vinod Kone.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Provides initial documentation to the public interfaces (thanks to Vinod Kone for pairing with me on this).
bq.  
bq.  
bq.  This addresses bug MESOS-45.
bq.      https://issues.apache.org/jira/browse/MESOS-45
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    include/mesos/executor.hpp d883f1a 
bq.    include/mesos/mesos.proto 77a9067 
bq.    include/mesos/scheduler.hpp 93dda98 
bq.    src/java/src/org/apache/mesos/Executor.java 5ad8cee 
bq.    src/java/src/org/apache/mesos/ExecutorDriver.java be01d21 
bq.    src/java/src/org/apache/mesos/MesosExecutorDriver.java 399c8b8 
bq.    src/java/src/org/apache/mesos/MesosSchedulerDriver.java 04809a6 
bq.    src/java/src/org/apache/mesos/Scheduler.java 63a06fe 
bq.    src/java/src/org/apache/mesos/SchedulerDriver.java 23a246c 
bq.    src/python/src/mesos.py 5fc60e2 
bq.  
bq.  Diff: https://reviews.apache.org/r/3442/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Benjamin
bq.  
bq.


                
> Document semantics and state transitions in mesos user-pluggable interfaces
> ---------------------------------------------------------------------------
>
>                 Key: MESOS-45
>                 URL: https://issues.apache.org/jira/browse/MESOS-45
>             Project: Mesos
>          Issue Type: Improvement
>          Components: c++-api, java-api, python-api
>            Reporter: John Sirois
>
> In particular, scheduler and executor lifecycle and re-entrancy requirements should be documented well either centrally, in a HOW-TO/spec or better, additionally or solely in binding interfaces in the supported languages (cpp, java, python).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MESOS-45) Document semantics and state transitions in mesos user-pluggable interfaces

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192822#comment-13192822 ] 

jiraposter@reviews.apache.org commented on MESOS-45:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3442/#review4577
-----------------------------------------------------------

Ship it!



src/java/src/org/apache/mesos/Executor.java
<https://reviews.apache.org/r/3442/#comment10205>

    syntax is one of:
    {@link #[localmethod]}
    {@link [otherclass]#[method]}



src/java/src/org/apache/mesos/MesosSchedulerDriver.java
<https://reviews.apache.org/r/3442/#comment10206>

    fix message


- John


On 2012-01-25 01:55:49, Benjamin Hindman wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3442/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-25 01:55:49)
bq.  
bq.  
bq.  Review request for mesos, Andy Konwinski, Charles Reiss, Matei Zaharia, John Sirois, and Vinod Kone.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Provides initial documentation to the public interfaces (thanks to Vinod Kone for pairing with me on this).
bq.  
bq.  
bq.  This addresses bug MESOS-45.
bq.      https://issues.apache.org/jira/browse/MESOS-45
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    include/mesos/executor.hpp 68f5bda 
bq.    include/mesos/mesos.proto 3c3f632 
bq.    include/mesos/scheduler.hpp 93dda98 
bq.    src/java/src/org/apache/mesos/Executor.java ea2b1a2 
bq.    src/java/src/org/apache/mesos/ExecutorDriver.java 66c2563 
bq.    src/java/src/org/apache/mesos/MesosExecutorDriver.java 2887f7b 
bq.    src/java/src/org/apache/mesos/MesosSchedulerDriver.java 90a193b 
bq.    src/java/src/org/apache/mesos/Scheduler.java c429a95 
bq.    src/java/src/org/apache/mesos/SchedulerDriver.java d31c9d1 
bq.    src/python/src/mesos.py d2088da 
bq.  
bq.  Diff: https://reviews.apache.org/r/3442/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Benjamin
bq.  
bq.


                
> Document semantics and state transitions in mesos user-pluggable interfaces
> ---------------------------------------------------------------------------
>
>                 Key: MESOS-45
>                 URL: https://issues.apache.org/jira/browse/MESOS-45
>             Project: Mesos
>          Issue Type: Improvement
>          Components: c++-api, java-api, python-api
>            Reporter: John Sirois
>
> In particular, scheduler and executor lifecycle and re-entrancy requirements should be documented well either centrally, in a HOW-TO/spec or better, additionally or solely in binding interfaces in the supported languages (cpp, java, python).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MESOS-45) Document semantics and state transitions in mesos user-pluggable interfaces

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188268#comment-13188268 ] 

jiraposter@reviews.apache.org commented on MESOS-45:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3442/#review4434
-----------------------------------------------------------



include/mesos/scheduler.hpp
<https://reviews.apache.org/r/3442/#comment9945>

    does this return?
    
    for example, if in launchTask(task) you get a malformed task, you'd think:
    
    {
      driver.sendStatusUpdate(...FAILED TASK...)
      driver.stop()
      <do I need to handle any cleanup conditions here?>
    }
    


- Brian


On 2012-01-10 06:48:03, Benjamin Hindman wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3442/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-10 06:48:03)
bq.  
bq.  
bq.  Review request for mesos, Andy Konwinski, Charles Reiss, Matei Zaharia, John Sirois, and Vinod Kone.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Provides initial documentation to the public interfaces (thanks to Vinod Kone for pairing with me on this).
bq.  
bq.  
bq.  This addresses bug MESOS-45.
bq.      https://issues.apache.org/jira/browse/MESOS-45
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    include/mesos/executor.hpp d883f1a 
bq.    include/mesos/mesos.proto 77a9067 
bq.    include/mesos/scheduler.hpp 93dda98 
bq.    src/java/src/org/apache/mesos/Executor.java 5ad8cee 
bq.    src/java/src/org/apache/mesos/ExecutorDriver.java be01d21 
bq.    src/java/src/org/apache/mesos/MesosExecutorDriver.java 399c8b8 
bq.    src/java/src/org/apache/mesos/MesosSchedulerDriver.java 04809a6 
bq.    src/java/src/org/apache/mesos/Scheduler.java 63a06fe 
bq.    src/java/src/org/apache/mesos/SchedulerDriver.java 23a246c 
bq.    src/python/src/mesos.py 5fc60e2 
bq.  
bq.  Diff: https://reviews.apache.org/r/3442/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Benjamin
bq.  
bq.


                
> Document semantics and state transitions in mesos user-pluggable interfaces
> ---------------------------------------------------------------------------
>
>                 Key: MESOS-45
>                 URL: https://issues.apache.org/jira/browse/MESOS-45
>             Project: Mesos
>          Issue Type: Improvement
>          Components: c++-api, java-api, python-api
>            Reporter: John Sirois
>
> In particular, scheduler and executor lifecycle and re-entrancy requirements should be documented well either centrally, in a HOW-TO/spec or better, additionally or solely in binding interfaces in the supported languages (cpp, java, python).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (MESOS-45) Document semantics and state transitions in mesos user-pluggable interfaces

Posted by "Benjamin Hindman (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MESOS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Hindman resolved MESOS-45.
-----------------------------------

    Resolution: Fixed
      Assignee: Benjamin Hindman

I'm closing this in favor of two more JIRAs that I'm going to file which target the Python docs and better Java docs.
                
> Document semantics and state transitions in mesos user-pluggable interfaces
> ---------------------------------------------------------------------------
>
>                 Key: MESOS-45
>                 URL: https://issues.apache.org/jira/browse/MESOS-45
>             Project: Mesos
>          Issue Type: Improvement
>          Components: c++-api, java-api, python-api
>            Reporter: John Sirois
>            Assignee: Benjamin Hindman
>
> In particular, scheduler and executor lifecycle and re-entrancy requirements should be documented well either centrally, in a HOW-TO/spec or better, additionally or solely in binding interfaces in the supported languages (cpp, java, python).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MESOS-45) Document semantics and state transitions in mesos user-pluggable interfaces

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192789#comment-13192789 ] 

jiraposter@reviews.apache.org commented on MESOS-45:
----------------------------------------------------



bq.  On 2012-01-18 04:50:17, Brian Wickman wrote:
bq.  > include/mesos/scheduler.hpp, line 175
bq.  > <https://reviews.apache.org/r/3442/diff/1/?file=67448#file67448line175>
bq.  >
bq.  >     does this return?
bq.  >     
bq.  >     for example, if in launchTask(task) you get a malformed task, you'd think:
bq.  >     
bq.  >     {
bq.  >       driver.sendStatusUpdate(...FAILED TASK...)
bq.  >       driver.stop()
bq.  >       <do I need to handle any cleanup conditions here?>
bq.  >     }
bq.  >

This function does indeed return. Any other calls on the driver will return a Status of DRIVER_STOPPED.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3442/#review4434
-----------------------------------------------------------


On 2012-01-25 01:55:49, Benjamin Hindman wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3442/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-25 01:55:49)
bq.  
bq.  
bq.  Review request for mesos, Andy Konwinski, Charles Reiss, Matei Zaharia, John Sirois, and Vinod Kone.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Provides initial documentation to the public interfaces (thanks to Vinod Kone for pairing with me on this).
bq.  
bq.  
bq.  This addresses bug MESOS-45.
bq.      https://issues.apache.org/jira/browse/MESOS-45
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    include/mesos/executor.hpp 68f5bda 
bq.    include/mesos/mesos.proto 3c3f632 
bq.    include/mesos/scheduler.hpp 93dda98 
bq.    src/java/src/org/apache/mesos/Executor.java ea2b1a2 
bq.    src/java/src/org/apache/mesos/ExecutorDriver.java 66c2563 
bq.    src/java/src/org/apache/mesos/MesosExecutorDriver.java 2887f7b 
bq.    src/java/src/org/apache/mesos/MesosSchedulerDriver.java 90a193b 
bq.    src/java/src/org/apache/mesos/Scheduler.java c429a95 
bq.    src/java/src/org/apache/mesos/SchedulerDriver.java d31c9d1 
bq.    src/python/src/mesos.py d2088da 
bq.  
bq.  Diff: https://reviews.apache.org/r/3442/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Benjamin
bq.  
bq.


                
> Document semantics and state transitions in mesos user-pluggable interfaces
> ---------------------------------------------------------------------------
>
>                 Key: MESOS-45
>                 URL: https://issues.apache.org/jira/browse/MESOS-45
>             Project: Mesos
>          Issue Type: Improvement
>          Components: c++-api, java-api, python-api
>            Reporter: John Sirois
>
> In particular, scheduler and executor lifecycle and re-entrancy requirements should be documented well either centrally, in a HOW-TO/spec or better, additionally or solely in binding interfaces in the supported languages (cpp, java, python).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MESOS-45) Document semantics and state transitions in mesos user-pluggable interfaces

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183306#comment-13183306 ] 

jiraposter@reviews.apache.org commented on MESOS-45:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3442/#review4294
-----------------------------------------------------------


This is very, very helpful.  Thanks.
I focused on the javadoc but threw in java api nits as well (from the perspective of a mesos library maintainer).
The javadoc should really follow http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html,  but the most glaring omissions are @parameter,@return docs.


src/java/src/org/apache/mesos/Scheduler.java
<https://reviews.apache.org/r/3442/#comment9675>

    The driver parameter in all methods other than register deserves explanation - must I use the it in the scope of the callback or is it always the same as the regsitered or ...?



src/java/src/org/apache/mesos/Scheduler.java
<https://reviews.apache.org/r/3442/#comment9676>

    There appears to be no need fo indexed access - Collection if you want to provide size, but it seems Iterable is fine here.



src/java/src/org/apache/mesos/SchedulerDriver.java
<https://reviews.apache.org/r/3442/#comment9671>

    s/public // - these are redundant for interface members



src/java/src/org/apache/mesos/SchedulerDriver.java
<https://reviews.apache.org/r/3442/#comment9672>

    how does this stop relate to the overload?  failover=true or false?



src/java/src/org/apache/mesos/SchedulerDriver.java
<https://reviews.apache.org/r/3442/#comment9673>

    Is Iterable enough for the impl? - if so prefer it.


- John


On 2012-01-10 06:48:03, Benjamin Hindman wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3442/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-10 06:48:03)
bq.  
bq.  
bq.  Review request for mesos, Andy Konwinski, Charles Reiss, Matei Zaharia, John Sirois, and Vinod Kone.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Provides initial documentation to the public interfaces (thanks to Vinod Kone for pairing with me on this).
bq.  
bq.  
bq.  This addresses bug MESOS-45.
bq.      https://issues.apache.org/jira/browse/MESOS-45
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    include/mesos/executor.hpp d883f1a 
bq.    include/mesos/mesos.proto 77a9067 
bq.    include/mesos/scheduler.hpp 93dda98 
bq.    src/java/src/org/apache/mesos/Executor.java 5ad8cee 
bq.    src/java/src/org/apache/mesos/ExecutorDriver.java be01d21 
bq.    src/java/src/org/apache/mesos/MesosExecutorDriver.java 399c8b8 
bq.    src/java/src/org/apache/mesos/MesosSchedulerDriver.java 04809a6 
bq.    src/java/src/org/apache/mesos/Scheduler.java 63a06fe 
bq.    src/java/src/org/apache/mesos/SchedulerDriver.java 23a246c 
bq.    src/python/src/mesos.py 5fc60e2 
bq.  
bq.  Diff: https://reviews.apache.org/r/3442/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Benjamin
bq.  
bq.


                
> Document semantics and state transitions in mesos user-pluggable interfaces
> ---------------------------------------------------------------------------
>
>                 Key: MESOS-45
>                 URL: https://issues.apache.org/jira/browse/MESOS-45
>             Project: Mesos
>          Issue Type: Improvement
>          Components: c++-api, java-api, python-api
>            Reporter: John Sirois
>
> In particular, scheduler and executor lifecycle and re-entrancy requirements should be documented well either centrally, in a HOW-TO/spec or better, additionally or solely in binding interfaces in the supported languages (cpp, java, python).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MESOS-45) Document semantics and state transitions in mesos user-pluggable interfaces

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193135#comment-13193135 ] 

jiraposter@reviews.apache.org commented on MESOS-45:
----------------------------------------------------



bq.  On 2012-01-25 02:53:08, John Sirois wrote:
bq.  >

Thanks John, submitting.


bq.  On 2012-01-25 02:53:08, John Sirois wrote:
bq.  > src/java/src/org/apache/mesos/Executor.java, line 33
bq.  > <https://reviews.apache.org/r/3442/diff/1-2/?file=67449#file67449line33>
bq.  >
bq.  >     syntax is one of:
bq.  >     {@link #[localmethod]}
bq.  >     {@link [otherclass]#[method]}

Great, done.


bq.  On 2012-01-25 02:53:08, John Sirois wrote:
bq.  > src/java/src/org/apache/mesos/MesosSchedulerDriver.java, line 73
bq.  > <https://reviews.apache.org/r/3442/diff/1-2/?file=67452#file67452line73>
bq.  >
bq.  >     fix message

Done.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3442/#review4577
-----------------------------------------------------------


On 2012-01-25 01:55:49, Benjamin Hindman wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3442/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-25 01:55:49)
bq.  
bq.  
bq.  Review request for mesos, Andy Konwinski, Charles Reiss, Matei Zaharia, John Sirois, and Vinod Kone.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Provides initial documentation to the public interfaces (thanks to Vinod Kone for pairing with me on this).
bq.  
bq.  
bq.  This addresses bug MESOS-45.
bq.      https://issues.apache.org/jira/browse/MESOS-45
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    include/mesos/executor.hpp 68f5bda 
bq.    include/mesos/mesos.proto 3c3f632 
bq.    include/mesos/scheduler.hpp 93dda98 
bq.    src/java/src/org/apache/mesos/Executor.java ea2b1a2 
bq.    src/java/src/org/apache/mesos/ExecutorDriver.java 66c2563 
bq.    src/java/src/org/apache/mesos/MesosExecutorDriver.java 2887f7b 
bq.    src/java/src/org/apache/mesos/MesosSchedulerDriver.java 90a193b 
bq.    src/java/src/org/apache/mesos/Scheduler.java c429a95 
bq.    src/java/src/org/apache/mesos/SchedulerDriver.java d31c9d1 
bq.    src/python/src/mesos.py d2088da 
bq.  
bq.  Diff: https://reviews.apache.org/r/3442/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Benjamin
bq.  
bq.


                
> Document semantics and state transitions in mesos user-pluggable interfaces
> ---------------------------------------------------------------------------
>
>                 Key: MESOS-45
>                 URL: https://issues.apache.org/jira/browse/MESOS-45
>             Project: Mesos
>          Issue Type: Improvement
>          Components: c++-api, java-api, python-api
>            Reporter: John Sirois
>
> In particular, scheduler and executor lifecycle and re-entrancy requirements should be documented well either centrally, in a HOW-TO/spec or better, additionally or solely in binding interfaces in the supported languages (cpp, java, python).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MESOS-45) Document semantics and state transitions in mesos user-pluggable interfaces

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192827#comment-13192827 ] 

jiraposter@reviews.apache.org commented on MESOS-45:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3442/#review4579
-----------------------------------------------------------

Ship it!



include/mesos/mesos.proto
<https://reviews.apache.org/r/3442/#comment10208>

    kill ws



src/java/src/org/apache/mesos/ExecutorDriver.java
<https://reviews.apache.org/r/3442/#comment10209>

    kill ws



src/java/src/org/apache/mesos/SchedulerDriver.java
<https://reviews.apache.org/r/3442/#comment10210>

    kill ws


- Vinod


On 2012-01-25 01:55:49, Benjamin Hindman wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3442/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-25 01:55:49)
bq.  
bq.  
bq.  Review request for mesos, Andy Konwinski, Charles Reiss, Matei Zaharia, John Sirois, and Vinod Kone.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Provides initial documentation to the public interfaces (thanks to Vinod Kone for pairing with me on this).
bq.  
bq.  
bq.  This addresses bug MESOS-45.
bq.      https://issues.apache.org/jira/browse/MESOS-45
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    include/mesos/executor.hpp 68f5bda 
bq.    include/mesos/mesos.proto 3c3f632 
bq.    include/mesos/scheduler.hpp 93dda98 
bq.    src/java/src/org/apache/mesos/Executor.java ea2b1a2 
bq.    src/java/src/org/apache/mesos/ExecutorDriver.java 66c2563 
bq.    src/java/src/org/apache/mesos/MesosExecutorDriver.java 2887f7b 
bq.    src/java/src/org/apache/mesos/MesosSchedulerDriver.java 90a193b 
bq.    src/java/src/org/apache/mesos/Scheduler.java c429a95 
bq.    src/java/src/org/apache/mesos/SchedulerDriver.java d31c9d1 
bq.    src/python/src/mesos.py d2088da 
bq.  
bq.  Diff: https://reviews.apache.org/r/3442/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Benjamin
bq.  
bq.


                
> Document semantics and state transitions in mesos user-pluggable interfaces
> ---------------------------------------------------------------------------
>
>                 Key: MESOS-45
>                 URL: https://issues.apache.org/jira/browse/MESOS-45
>             Project: Mesos
>          Issue Type: Improvement
>          Components: c++-api, java-api, python-api
>            Reporter: John Sirois
>
> In particular, scheduler and executor lifecycle and re-entrancy requirements should be documented well either centrally, in a HOW-TO/spec or better, additionally or solely in binding interfaces in the supported languages (cpp, java, python).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MESOS-45) Document semantics and state transitions in mesos user-pluggable interfaces

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183377#comment-13183377 ] 

jiraposter@reviews.apache.org commented on MESOS-45:
----------------------------------------------------



bq.  On 2012-01-10 14:26:24, John Sirois wrote:
bq.  > src/java/src/org/apache/mesos/Scheduler.java, line 57
bq.  > <https://reviews.apache.org/r/3442/diff/1/?file=67453#file67453line57>
bq.  >
bq.  >     There appears to be no need fo indexed access - Collection if you want to provide size, but it seems Iterable is fine here.
bq.  
bq.  Matei Zaharia wrote:
bq.      Going over the offers in the same order multiple times is useful in complex schedulers -- for example, we do it in Spark. I suggest leaving it this way, unless you want everyone to copy their Collection to a list. I can't anticipate a scenario when it would be more efficient to use an unordered collection here, and in other languages, such as Python, the collection will be ordered anyway.

The comment wasn't derived from efficiency concerns - a List could still be passed since its Iterable.  I was suggesting this change as an api maintainer - Iterable gives you more freedom going forward to change implementation without breaking clients and your clients still get a sequence of offers they can repeatedly iterate over.  You might add extra javadoc that says the iterators are guaranteed to be stable wrt each other, but this is implicit for all Iterables I've encountered in java land.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3442/#review4294
-----------------------------------------------------------


On 2012-01-10 06:48:03, Benjamin Hindman wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3442/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-10 06:48:03)
bq.  
bq.  
bq.  Review request for mesos, Andy Konwinski, Charles Reiss, Matei Zaharia, John Sirois, and Vinod Kone.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Provides initial documentation to the public interfaces (thanks to Vinod Kone for pairing with me on this).
bq.  
bq.  
bq.  This addresses bug MESOS-45.
bq.      https://issues.apache.org/jira/browse/MESOS-45
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    include/mesos/executor.hpp d883f1a 
bq.    include/mesos/mesos.proto 77a9067 
bq.    include/mesos/scheduler.hpp 93dda98 
bq.    src/java/src/org/apache/mesos/Executor.java 5ad8cee 
bq.    src/java/src/org/apache/mesos/ExecutorDriver.java be01d21 
bq.    src/java/src/org/apache/mesos/MesosExecutorDriver.java 399c8b8 
bq.    src/java/src/org/apache/mesos/MesosSchedulerDriver.java 04809a6 
bq.    src/java/src/org/apache/mesos/Scheduler.java 63a06fe 
bq.    src/java/src/org/apache/mesos/SchedulerDriver.java 23a246c 
bq.    src/python/src/mesos.py 5fc60e2 
bq.  
bq.  Diff: https://reviews.apache.org/r/3442/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Benjamin
bq.  
bq.


                
> Document semantics and state transitions in mesos user-pluggable interfaces
> ---------------------------------------------------------------------------
>
>                 Key: MESOS-45
>                 URL: https://issues.apache.org/jira/browse/MESOS-45
>             Project: Mesos
>          Issue Type: Improvement
>          Components: c++-api, java-api, python-api
>            Reporter: John Sirois
>
> In particular, scheduler and executor lifecycle and re-entrancy requirements should be documented well either centrally, in a HOW-TO/spec or better, additionally or solely in binding interfaces in the supported languages (cpp, java, python).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MESOS-45) Document semantics and state transitions in mesos user-pluggable interfaces

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183116#comment-13183116 ] 

jiraposter@reviews.apache.org commented on MESOS-45:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3442/
-----------------------------------------------------------

Review request for mesos, Andy Konwinski, Charles Reiss, Matei Zaharia, John Sirois, and Vinod Kone.


Summary
-------

Provides initial documentation to the public interfaces (thanks to Vinod Kone for pairing with me on this).


This addresses bug MESOS-45.
    https://issues.apache.org/jira/browse/MESOS-45


Diffs
-----

  include/mesos/executor.hpp d883f1a 
  include/mesos/mesos.proto 77a9067 
  include/mesos/scheduler.hpp 93dda98 
  src/java/src/org/apache/mesos/Executor.java 5ad8cee 
  src/java/src/org/apache/mesos/ExecutorDriver.java be01d21 
  src/java/src/org/apache/mesos/MesosExecutorDriver.java 399c8b8 
  src/java/src/org/apache/mesos/MesosSchedulerDriver.java 04809a6 
  src/java/src/org/apache/mesos/Scheduler.java 63a06fe 
  src/java/src/org/apache/mesos/SchedulerDriver.java 23a246c 
  src/python/src/mesos.py 5fc60e2 

Diff: https://reviews.apache.org/r/3442/diff


Testing
-------


Thanks,

Benjamin


                
> Document semantics and state transitions in mesos user-pluggable interfaces
> ---------------------------------------------------------------------------
>
>                 Key: MESOS-45
>                 URL: https://issues.apache.org/jira/browse/MESOS-45
>             Project: Mesos
>          Issue Type: Improvement
>          Components: c++-api, java-api, python-api
>            Reporter: John Sirois
>
> In particular, scheduler and executor lifecycle and re-entrancy requirements should be documented well either centrally, in a HOW-TO/spec or better, additionally or solely in binding interfaces in the supported languages (cpp, java, python).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MESOS-45) Document semantics and state transitions in mesos user-pluggable interfaces

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192788#comment-13192788 ] 

jiraposter@reviews.apache.org commented on MESOS-45:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3442/
-----------------------------------------------------------

(Updated 2012-01-25 01:55:49.582124)


Review request for mesos, Andy Konwinski, Charles Reiss, Matei Zaharia, John Sirois, and Vinod Kone.


Changes
-------

Updates based on John Sirois comments.


Summary
-------

Provides initial documentation to the public interfaces (thanks to Vinod Kone for pairing with me on this).


This addresses bug MESOS-45.
    https://issues.apache.org/jira/browse/MESOS-45


Diffs (updated)
-----

  include/mesos/executor.hpp 68f5bda 
  include/mesos/mesos.proto 3c3f632 
  include/mesos/scheduler.hpp 93dda98 
  src/java/src/org/apache/mesos/Executor.java ea2b1a2 
  src/java/src/org/apache/mesos/ExecutorDriver.java 66c2563 
  src/java/src/org/apache/mesos/MesosExecutorDriver.java 2887f7b 
  src/java/src/org/apache/mesos/MesosSchedulerDriver.java 90a193b 
  src/java/src/org/apache/mesos/Scheduler.java c429a95 
  src/java/src/org/apache/mesos/SchedulerDriver.java d31c9d1 
  src/python/src/mesos.py d2088da 

Diff: https://reviews.apache.org/r/3442/diff


Testing
-------


Thanks,

Benjamin


                
> Document semantics and state transitions in mesos user-pluggable interfaces
> ---------------------------------------------------------------------------
>
>                 Key: MESOS-45
>                 URL: https://issues.apache.org/jira/browse/MESOS-45
>             Project: Mesos
>          Issue Type: Improvement
>          Components: c++-api, java-api, python-api
>            Reporter: John Sirois
>
> In particular, scheduler and executor lifecycle and re-entrancy requirements should be documented well either centrally, in a HOW-TO/spec or better, additionally or solely in binding interfaces in the supported languages (cpp, java, python).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MESOS-45) Document semantics and state transitions in mesos user-pluggable interfaces

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183473#comment-13183473 ] 

jiraposter@reviews.apache.org commented on MESOS-45:
----------------------------------------------------



bq.  On 2012-01-10 14:26:24, John Sirois wrote:
bq.  > src/java/src/org/apache/mesos/Scheduler.java, line 57
bq.  > <https://reviews.apache.org/r/3442/diff/1/?file=67453#file67453line57>
bq.  >
bq.  >     There appears to be no need fo indexed access - Collection if you want to provide size, but it seems Iterable is fine here.
bq.  
bq.  Matei Zaharia wrote:
bq.      Going over the offers in the same order multiple times is useful in complex schedulers -- for example, we do it in Spark. I suggest leaving it this way, unless you want everyone to copy their Collection to a list. I can't anticipate a scenario when it would be more efficient to use an unordered collection here, and in other languages, such as Python, the collection will be ordered anyway.
bq.  
bq.  John Sirois wrote:
bq.      The comment wasn't derived from efficiency concerns - a List could still be passed since its Iterable.  I was suggesting this change as an api maintainer - Iterable gives you more freedom going forward to change implementation without breaking clients and your clients still get a sequence of offers they can repeatedly iterate over.  You might add extra javadoc that says the iterators are guaranteed to be stable wrt each other, but this is implicit for all Iterables I've encountered in java land.

I realize that the comment isn't from efficiency concerns, but I'm just saying that I can't imagine a case where the implementation would change in a way that prevents meeting the List interface. Just to be clear, the code I'm talking about doesn't simply want to iterate over the list multiple times -- it wants to know the size of the list and keep some data about each machine offered, and it does use indexes into it. For example, here's a common thing to do: you have a list of tasks you want to launch and a list of machines offered, and you want to spread your tasks across the machines in a round-robin manner as long as they have enough resources. You can do something like this:

memoryLeft = // int array initialized to the memory on each machine
cpusLeft = // int array initialized to the CPUs on each machine
while (tasksToLaunch > 0) {
  for (i = 0 to offers.size) {
    if (memoryLeft[i] >= taskMemory && cpusLeft[i] >= taskCpus) {
      launch a task on machine i
      decrease memoryLeft[i] and cpusLeft[i]
    }
  }
}

Basically, by not providing a List, you're losing some usability without gaining much maintainability. I agree you shouldn't be providing an array or something, but giving a less convenient collection type for something that is already an ordered collection in other languages seems overly picky.


- Matei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3442/#review4294
-----------------------------------------------------------


On 2012-01-10 06:48:03, Benjamin Hindman wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3442/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-10 06:48:03)
bq.  
bq.  
bq.  Review request for mesos, Andy Konwinski, Charles Reiss, Matei Zaharia, John Sirois, and Vinod Kone.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Provides initial documentation to the public interfaces (thanks to Vinod Kone for pairing with me on this).
bq.  
bq.  
bq.  This addresses bug MESOS-45.
bq.      https://issues.apache.org/jira/browse/MESOS-45
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    include/mesos/executor.hpp d883f1a 
bq.    include/mesos/mesos.proto 77a9067 
bq.    include/mesos/scheduler.hpp 93dda98 
bq.    src/java/src/org/apache/mesos/Executor.java 5ad8cee 
bq.    src/java/src/org/apache/mesos/ExecutorDriver.java be01d21 
bq.    src/java/src/org/apache/mesos/MesosExecutorDriver.java 399c8b8 
bq.    src/java/src/org/apache/mesos/MesosSchedulerDriver.java 04809a6 
bq.    src/java/src/org/apache/mesos/Scheduler.java 63a06fe 
bq.    src/java/src/org/apache/mesos/SchedulerDriver.java 23a246c 
bq.    src/python/src/mesos.py 5fc60e2 
bq.  
bq.  Diff: https://reviews.apache.org/r/3442/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Benjamin
bq.  
bq.


                
> Document semantics and state transitions in mesos user-pluggable interfaces
> ---------------------------------------------------------------------------
>
>                 Key: MESOS-45
>                 URL: https://issues.apache.org/jira/browse/MESOS-45
>             Project: Mesos
>          Issue Type: Improvement
>          Components: c++-api, java-api, python-api
>            Reporter: John Sirois
>
> In particular, scheduler and executor lifecycle and re-entrancy requirements should be documented well either centrally, in a HOW-TO/spec or better, additionally or solely in binding interfaces in the supported languages (cpp, java, python).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira