You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2020/08/21 14:37:51 UTC
Re: Review Request 72788: Introduced the
`CSIPluginInfo.target_path_exists` field.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72788/
-----------------------------------------------------------
(Updated Aug. 21, 2020, 10:37 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Changed the solution by introducing a protobuf message field `CSIPluginInfo.target_path_exists`.
Summary (updated)
-----------------
Introduced the `CSIPluginInfo.target_path_exists` field.
Bugs: MESOS-10150
https://issues.apache.org/jira/browse/MESOS-10150
Repository: mesos
Description (updated)
-------
Introduced the `CSIPluginInfo.target_path_exists` field.
Diffs (updated)
-----
include/mesos/mesos.proto 661f746dda9c1d2350867bd9139e73c3e3a34f5d
include/mesos/v1/mesos.proto ffe45c305ab46c73f0da5908287aa3eab8ecf5dd
src/csi/v1_volume_manager.cpp c05265cd514de745e824c16a0acef276deed1510
Diff: https://reviews.apache.org/r/72788/diff/2/
Changes: https://reviews.apache.org/r/72788/diff/1-2/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 72788: Introduced the
`CSIPluginInfo.target_path_exists` field.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72788/#review221677
-----------------------------------------------------------
Bad patch!
Reviews applied: [72788]
Failed command: cd .. && /usr/bin/python3 support/apply-reviews.py -n -r 72788
Error:
2020-08-21 16:09:15 URL:https://reviews.apache.org/r/72788/diff/raw/ [4332/4332] -> "72788.patch" [1]
*** Please tell me who you are.
Run
git config --global user.email "you@example.com"
git config --global user.name "Your Name"
to set your account's default identity.
Omit --global to set the identity only in this repository.
fatal: empty ident name (for <je...@asf931.gq1.ygridcore.net>) not allowed
Full log: https://ci-builds.apache.org/job/Mesos/job/Mesos-Reviewbot-Linux/15/console
- Mesos Reviewbot
On Aug. 21, 2020, 2:37 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72788/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2020, 2:37 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10150
> https://issues.apache.org/jira/browse/MESOS-10150
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Introduced the `CSIPluginInfo.target_path_exists` field.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 661f746dda9c1d2350867bd9139e73c3e3a34f5d
> include/mesos/v1/mesos.proto ffe45c305ab46c73f0da5908287aa3eab8ecf5dd
> src/csi/v1_volume_manager.cpp c05265cd514de745e824c16a0acef276deed1510
>
>
> Diff: https://reviews.apache.org/r/72788/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72788: Introduced the
`CSIPluginInfo.target_path_exists` field.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72788/#review221679
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Aug. 21, 2020, 2:37 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72788/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2020, 2:37 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10150
> https://issues.apache.org/jira/browse/MESOS-10150
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Introduced the `CSIPluginInfo.target_path_exists` field.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 661f746dda9c1d2350867bd9139e73c3e3a34f5d
> include/mesos/v1/mesos.proto ffe45c305ab46c73f0da5908287aa3eab8ecf5dd
> src/csi/v1_volume_manager.cpp c05265cd514de745e824c16a0acef276deed1510
>
>
> Diff: https://reviews.apache.org/r/72788/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 72788: Introduced the
`CSIPluginInfo.target_path_exists` field.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72788/
-----------------------------------------------------------
(Updated Aug. 25, 2020, 9:23 a.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Bugs: MESOS-10148
https://issues.apache.org/jira/browse/MESOS-10148
Repository: mesos
Description
-------
Introduced the `CSIPluginInfo.target_path_exists` field.
Diffs
-----
include/mesos/mesos.proto 661f746dda9c1d2350867bd9139e73c3e3a34f5d
include/mesos/v1/mesos.proto ffe45c305ab46c73f0da5908287aa3eab8ecf5dd
src/csi/v1_volume_manager.cpp c05265cd514de745e824c16a0acef276deed1510
Diff: https://reviews.apache.org/r/72788/diff/2/
Testing
-------
Thanks,
Qian Zhang