You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2015/12/19 08:30:20 UTC
[GitHub] incubator-zeppelin pull request: table scrolling bug fixed. out of...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/556
table scrolling bug fixed. out of area scroll issue
### What is this PR for?
Scrollbar position when you scroll through the table has been modified with parts that are expressed differently in the length of the actual data.
### What type of PR is it?
Bug Fix
### Todos
- [x] Perfect Scroll-based Zeppelin scroll bug fix
- [x] Browser Test
- [x] Safari (9.0.2(11601.3.9)
- [x] Firefox (43.0)
- [x] Chrome (47.0.2526.106 (64-bit)
### Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-523
### How should this be tested?
Step 1. create table on zeppelin
example query)
``` python
%pyspark
TABLE = "%table Header1\tHeader2\n"
for x in range(1,51):
#TABLE += "scroll";
TABLE += str(x);
if (x%2) == 0:
TABLE += "\n"
else:
TABLE += "\t"
z.put("table_context", TABLE)
```
``` scala
println(z.get("table_context"))
```
Step 2.
Scroll the mouse over the Table.
### Screenshots (if appropriate)
#### Before
#### After
### Questions:
Why did this problem occur?
- ref. https://github.com/noraesae/perfect-scrollbar#how-to-use perfect scrollbar library.
height calculation miss.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/incubator-zeppelin bug_fix/table_scrolling
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/556.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #556
----
commit a0db646f1e0f12ef5f07c0db711f1d88e9f1fece
Author: CloverHearts <es...@gmail.com>
Date: 2015-12-19T06:16:04Z
table scrolling bug fixed. out of area scroll issue
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-523 ] table scrolling bu...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/556#issuecomment-166167993
@r-kamath Thank you for Feed back!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-523 ] table scrolling bu...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/556#issuecomment-166169719
@cloverhearts I just merged #554, since those two PRs are making changes on the same component, could you rebase this PR so that we can check that everything still work?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-523 ] table scrolling bu...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/556#issuecomment-166211258
@prabhjyotsingh
Thank you good feedback.
I know that this is a bug.
This bug is that I created a PR and is unrelated to a bug, the bug that already exist in the past.
But I have an idea to fix this bug.
I hope to create a new PR after fix this bug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-523 ] table scrolling bu...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/556#issuecomment-166055415
Tested, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-523 ] table scrolling bu...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/556#issuecomment-166058799
@astroshim @corneadoug Thank you for Feed back! Have a nice day~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-523 ] table scrolling bu...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/556#issuecomment-166117118
@cloverhearts Thanks for the fix. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-523 ] table scrolling bu...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/556#issuecomment-166199625
rebase complete
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-523 ] table scrolling bu...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/556#issuecomment-166211517
I close this PR.
And I will make a new PR fix the known bugs table.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-523 ] table scrolling bu...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/556
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-523 ] table scrolling bu...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/556#issuecomment-166205523
Wired bug, scroll dosent show after running the paragraph. Happens in all the browsers.
Apart for this, works good, tested on IE10, FF, Chrome and Safari.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-523 ] table scrolling bu...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/556#issuecomment-166171145
@corneadoug
Sorry. I tried to test with the # 554 and # 556.
# 556 is a single action results, it was confirmed that # 554 is not running.
I want to create a separate PR or to fix a problem in this area, or seems to need to upload the modified code to the current PR.
I'm sorry to bother you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-523 ] table scrolling bu...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/556#issuecomment-166170352
@corneadoug okay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-523 ] table scrolling bu...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/556#issuecomment-166173543
@cloverhearts don't really understand, but to rebase you need to do:
```
git fetch incubator-zeppelin
git rebase incubator-zeppelin/master
git pull -f (after fixing potential conflicts)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-523 ] table scrolling bu...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/556#issuecomment-165959908
Cool fix!
I tested on chrome/firefox/explore10 and working well.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---