You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by David Nalley <da...@gnsa.us> on 2012/05/17 06:24:24 UTC

Fwd: [PATCH] CS-14955: security_group.py only creates ICMP iptables rules for ICMP type -1 (#10)

---------- Forwarded message ----------
From: John Kinsella
<re...@reply.github.com>
Date: Wed, May 16, 2012 at 10:54 PM
Subject: [CloudStack] CS-14955: security_group.py only creates ICMP
iptables rules for ICMP type -1 (#10)
To:


Description:
Unindented 3 lines to update logic flow to execute iptables when
passed ICMP type is not -1.

You can merge this Pull Request by running:

 git pull https://github.com/jlk/CloudStack master

Or you can view, comment on it, or merge it online at:

 https://github.com/CloudStack/CloudStack/pull/10

-- Commit Summary --

* CS-14955: security_group.py only creates ICMP iptables rules for

-- File Changes --

M scripts/vm/network/security_group.py (6)

-- Patch Links --

 https://github.com/CloudStack/CloudStack/pull/10.patch
 https://github.com/CloudStack/CloudStack/pull/10.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/CloudStack/CloudStack/pull/10

Re: [PATCH] CS-14955: security_group.py only creates ICMP iptables rules for ICMP type -1 (#10)

Posted by David Nalley <da...@gnsa.us>.
On Thu, May 17, 2012 at 12:38 PM, Edison Su <Ed...@citrix.com> wrote:
> Thanks for the fix, looks good to me.
> David, If I want to pull this patch into cloudstack, do I just do it?
>

Edison,

Just to try and get us caught up on patches in the queue - since you
approved this I went ahead and merged it.

John, thanks for the patch.

--David

Re: [PATCH] CS-14955: security_group.py only creates ICMP iptables rules for ICMP type -1 (#10)

Posted by David Nalley <da...@gnsa.us>.
On Fri, May 18, 2012 at 3:09 AM, John Kinsella <jl...@stratosec.co> wrote:
> On May 17, 2012, at 10:57 PM, David Nalley wrote:
>> On Thu, May 17, 2012 at 12:42 PM, John Kinsella <jl...@stratosec.co> wrote:
>>> I'd like to document the process for Apache CloudStack, as well...for this
>>> one I sent a pull request to CloudStack on github, but I suspect that
>>> process is going to change in the coming weeks...
>> So a couple of comments.
>>
>> We can mirror our ASF repo to github, and accept patches to pull
>> requests apparently. (For those I misinformed privately about this
>> fact - I apologize - at the time I was unaware of github mirroring.)
>>
>> But I think we should also have patches sent to the list via git
>> format-patch - and perhaps a few other ways. I am personally keen on
>> preserving proper attribution in git log, so a diff isn't quite
>> enough.
>
> Concur. How has that been working so far? Seems too easy for people to send a pull request and just expect that's it, versus specifying that changes will only be accepted via patches sent to the dev list or to the maintainers - I'm thinking about how the Linux kernel does this, although that might be overkill...
>


Others experiences might vary, but from my personal reviewer/committer
perspective, patches sent to the mailing list with git format-patch
are super easy for me to deal with, and the pull requests from github
are also easy - but not as easy.

--David

Re: [PATCH] CS-14955: security_group.py only creates ICMP iptables rules for ICMP type -1 (#10)

Posted by John Kinsella <jl...@stratosec.co>.
On May 17, 2012, at 10:57 PM, David Nalley wrote:
> On Thu, May 17, 2012 at 12:42 PM, John Kinsella <jl...@stratosec.co> wrote:
>> I'd like to document the process for Apache CloudStack, as well...for this
>> one I sent a pull request to CloudStack on github, but I suspect that
>> process is going to change in the coming weeks...
> So a couple of comments.
> 
> We can mirror our ASF repo to github, and accept patches to pull
> requests apparently. (For those I misinformed privately about this
> fact - I apologize - at the time I was unaware of github mirroring.)
> 
> But I think we should also have patches sent to the list via git
> format-patch - and perhaps a few other ways. I am personally keen on
> preserving proper attribution in git log, so a diff isn't quite
> enough.

Concur. How has that been working so far? Seems too easy for people to send a pull request and just expect that's it, versus specifying that changes will only be accepted via patches sent to the dev list or to the maintainers - I'm thinking about how the Linux kernel does this, although that might be overkill...


Re: [PATCH] CS-14955: security_group.py only creates ICMP iptables rules for ICMP type -1 (#10)

Posted by David Nalley <da...@gnsa.us>.
On Thu, May 17, 2012 at 12:42 PM, John Kinsella <jl...@stratosec.co> wrote:
> I'd like to document the process for Apache CloudStack, as well...for this
> one I sent a pull request to CloudStack on github, but I suspect that
> process is going to change in the coming weeks...
>


So a couple of comments.

We can mirror our ASF repo to github, and accept patches to pull
requests apparently. (For those I misinformed privately about this
fact - I apologize - at the time I was unaware of github mirroring.)

But I think we should also have patches sent to the list via git
format-patch - and perhaps a few other ways. I am personally keen on
preserving proper attribution in git log, so a diff isn't quite
enough.

--David

Re: [PATCH] CS-14955: security_group.py only creates ICMP iptables rules for ICMP type -1 (#10)

Posted by John Kinsella <jl...@stratosec.co>.
I'd like to document the process for Apache CloudStack, as well...for this one I sent a pull request to CloudStack on github, but I suspect that process is going to change in the coming weeks...

John

On May 17, 2012, at 9:38 AM, Edison Su wrote:

> Thanks for the fix, looks good to me. 
> David, If I want to pull this patch into cloudstack, do I just do it? 
> 
>> -----Original Message-----
>> From: David Nalley [mailto:david@gnsa.us]
>> Sent: Wednesday, May 16, 2012 9:24 PM
>> To: cloudstack-dev@incubator.apache.org
>> Subject: Fwd: [PATCH] CS-14955: security_group.py only creates ICMP
>> iptables rules for ICMP type -1 (#10)
>> 
>> ---------- Forwarded message ----------
>> From: John Kinsella
>> <reply+i-4618094-5076ad5f2a6de057314b343bf37e89569aadf6c7-
>> 1129409@reply.github.com>
>> Date: Wed, May 16, 2012 at 10:54 PM
>> Subject: [CloudStack] CS-14955: security_group.py only creates ICMP
>> iptables rules for ICMP type -1 (#10)
>> To:
>> 
>> 
>> Description:
>> Unindented 3 lines to update logic flow to execute iptables when
>> passed ICMP type is not -1.
>> 
>> You can merge this Pull Request by running:
>> 
>>  git pull https://github.com/jlk/CloudStack master
>> 
>> Or you can view, comment on it, or merge it online at:
>> 
>>  https://github.com/CloudStack/CloudStack/pull/10
>> 
>> -- Commit Summary --
>> 
>> * CS-14955: security_group.py only creates ICMP iptables rules for
>> 
>> -- File Changes --
>> 
>> M scripts/vm/network/security_group.py (6)
>> 
>> -- Patch Links --
>> 
>>  https://github.com/CloudStack/CloudStack/pull/10.patch
>>  https://github.com/CloudStack/CloudStack/pull/10.diff
>> 
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/CloudStack/CloudStack/pull/10



RE: [PATCH] CS-14955: security_group.py only creates ICMP iptables rules for ICMP type -1 (#10)

Posted by Edison Su <Ed...@citrix.com>.
Thanks for the fix, looks good to me. 
David, If I want to pull this patch into cloudstack, do I just do it? 

> -----Original Message-----
> From: David Nalley [mailto:david@gnsa.us]
> Sent: Wednesday, May 16, 2012 9:24 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: Fwd: [PATCH] CS-14955: security_group.py only creates ICMP
> iptables rules for ICMP type -1 (#10)
> 
> ---------- Forwarded message ----------
> From: John Kinsella
> <reply+i-4618094-5076ad5f2a6de057314b343bf37e89569aadf6c7-
> 1129409@reply.github.com>
> Date: Wed, May 16, 2012 at 10:54 PM
> Subject: [CloudStack] CS-14955: security_group.py only creates ICMP
> iptables rules for ICMP type -1 (#10)
> To:
> 
> 
> Description:
> Unindented 3 lines to update logic flow to execute iptables when
> passed ICMP type is not -1.
> 
> You can merge this Pull Request by running:
> 
>  git pull https://github.com/jlk/CloudStack master
> 
> Or you can view, comment on it, or merge it online at:
> 
>  https://github.com/CloudStack/CloudStack/pull/10
> 
> -- Commit Summary --
> 
> * CS-14955: security_group.py only creates ICMP iptables rules for
> 
> -- File Changes --
> 
> M scripts/vm/network/security_group.py (6)
> 
> -- Patch Links --
> 
>  https://github.com/CloudStack/CloudStack/pull/10.patch
>  https://github.com/CloudStack/CloudStack/pull/10.diff
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/CloudStack/CloudStack/pull/10