[jira] [Commented] (NIFI-5170) Update Grok to 0.1.9

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468996#comment-16468996 ] 

ASF GitHub Bot commented on NIFI-5170:
--------------------------------------

GitHub user ottobackwards opened a pull request:

    https://github.com/apache/nifi/pull/2691

    NIFI-5170 Upgrad Grok to version 0.1.9

    Upgrade to the new java-grok release and update for changes in the library.
    This includes:
    
    - Changes to the namespace from io.thekraken to io.krakens
    - Refactoring to use the new GrokCompiler api
    - Refactoring to do customValidation, since Grok will throw an IllegalArgumentException is an expression
    references a Grok that is not defined, which is a change of behavior
    
    - ExtractGrok now supports the default patterns, so the patterns file property is no longer required
    
    Handles both the Record Reader and Legacy Processor
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ottobackwards/nifi update-grok-019

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2691.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2691
    
----
commit d05d72830cfb63458f5f87213be5a64ca12c3270
Author: Otto Fowler <ot...@...>
Date:   2018-05-08T19:53:20Z

    NIFI-5170 Upgrad Grok to version 0.1.9
    
    Upgrade to the new java-grok release and update for changes in the library.
    This includes:
    
    - Changes to the namespace from io.thekraken to io.krakens
    - Refactoring to use the new GrokCompiler api
    - Refactoring to do customValidation, since Grok will throw an IllegalArgumentException is an expression
    references a Grok that is not defined, which is a change of behavior
    
    Handles both the Record Reader and Legacy Processor

----


> Update Grok to 0.1.9
> --------------------
>
>                 Key: NIFI-5170
>                 URL: https://issues.apache.org/jira/browse/NIFI-5170
>             Project: Apache NiFi
>          Issue Type: New Feature
>            Reporter: Otto Fowler
>            Assignee: Otto Fowler
>            Priority: Major
>
> Grok 0.1.9 has been released, including work for empty capture support.
>  
> https://github.com/thekrakken/java-grok#maven-repository



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)