You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2024/10/17 16:52:22 UTC
[PR] Using single temp maven local repository for release validation tasks [beam]
Abacn opened a new pull request, #32841:
URL: https://github.com/apache/beam/pull/32841
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Using single temp maven local repository for release validation tasks [beam]
Posted by "chamikaramj (via GitHub)" <gi...@apache.org>.
chamikaramj commented on PR #32841:
URL: https://github.com/apache/beam/pull/32841#issuecomment-2427692897
Seems like this fix wasn't adequate or this resulted in a different regression.
https://ge.apache.org/s/73edbo72xzrt4/console-log/task/:runners:google-cloud-dataflow-java:runMobileGamingJavaDataflowBom?anchor=97&page=1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Using single temp maven local repository for release validation tasks [beam]
Posted by "chamikaramj (via GitHub)" <gi...@apache.org>.
chamikaramj commented on code in PR #32841:
URL: https://github.com/apache/beam/pull/32841#discussion_r1805374681
##########
release/src/main/groovy/TestScripts.groovy:
##########
@@ -209,16 +220,17 @@ class TestScripts {
</profile>
</profiles>
</settings>
- """
- def cmd = "mvn ${args} -s ${settings.absolutePath} -Ptestrel -B"
- String path = System.getenv("PATH");
- // Set the path on jenkins executors to use a recent maven
- // MAVEN_HOME is not set on some executors, so default to 3.5.2
- String maven_home = System.getenv("MAVEN_HOME") ?: '/home/jenkins/tools/maven/apache-maven-3.5.4'
- println "Using maven ${maven_home}"
- def mvnPath = "${maven_home}/bin"
- def setPath = "export PATH=\"${mvnPath}:${path}\" && "
- return _execute(setPath + cmd)
+ """
+ }
+ def cmd = "mvn ${args} -s ${settings.absolutePath} -Ptestrel -B"
Review Comment:
Shall we also add "-U" in addition to this change ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Using single temp maven local repository for release validation tasks [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #32841:
URL: https://github.com/apache/beam/pull/32841#discussion_r1805708499
##########
release/src/main/groovy/TestScripts.groovy:
##########
@@ -209,16 +220,17 @@ class TestScripts {
</profile>
</profiles>
</settings>
- """
- def cmd = "mvn ${args} -s ${settings.absolutePath} -Ptestrel -B"
- String path = System.getenv("PATH");
- // Set the path on jenkins executors to use a recent maven
- // MAVEN_HOME is not set on some executors, so default to 3.5.2
- String maven_home = System.getenv("MAVEN_HOME") ?: '/home/jenkins/tools/maven/apache-maven-3.5.4'
- println "Using maven ${maven_home}"
- def mvnPath = "${maven_home}/bin"
- def setPath = "export PATH=\"${mvnPath}:${path}\" && "
- return _execute(setPath + cmd)
+ """
+ }
+ def cmd = "mvn ${args} -s ${settings.absolutePath} -Ptestrel -B"
Review Comment:
Sorry later on I found my initial investigation in https://github.com/apache/beam/issues/32824#issuecomment-2419679190 was wrong. In particular, the test workflow runs 8 tasks in parallel, each spin up an individual maven local repository, and delete after finish. So there isn't exist scenario that bad local repository cached can interfere the next run.
Using `-U` tag will cause the workflow making more requests to maven snapshot repository, which is known to be less stable in terms of availability, and I am afraid it would worsen rate limiting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Using single temp maven local repository for release validation tasks [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #32841:
URL: https://github.com/apache/beam/pull/32841#discussion_r1805708499
##########
release/src/main/groovy/TestScripts.groovy:
##########
@@ -209,16 +220,17 @@ class TestScripts {
</profile>
</profiles>
</settings>
- """
- def cmd = "mvn ${args} -s ${settings.absolutePath} -Ptestrel -B"
- String path = System.getenv("PATH");
- // Set the path on jenkins executors to use a recent maven
- // MAVEN_HOME is not set on some executors, so default to 3.5.2
- String maven_home = System.getenv("MAVEN_HOME") ?: '/home/jenkins/tools/maven/apache-maven-3.5.4'
- println "Using maven ${maven_home}"
- def mvnPath = "${maven_home}/bin"
- def setPath = "export PATH=\"${mvnPath}:${path}\" && "
- return _execute(setPath + cmd)
+ """
+ }
+ def cmd = "mvn ${args} -s ${settings.absolutePath} -Ptestrel -B"
Review Comment:
Sorry later on I found my initial investigation in https://github.com/apache/beam/issues/32824#issuecomment-2419679190 was wrong. In particular, the test workflow 8 tasks in parallel, each spin up an individual maven local repository, and delete after finish. So there isn't exist scenario that bad local repository cached can interfere the next run.
Using `-U` tag will cause the workflow making more requests to maven snapshot repository, which is known to be less stable in terms of availability, and I am afraid it would worsen rate limiting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Using single temp maven local repository for release validation tasks [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #32841:
URL: https://github.com/apache/beam/pull/32841#issuecomment-2420285202
assign set of reviewers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Using single temp maven local repository for release validation tasks [beam]
Posted by "chamikaramj (via GitHub)" <gi...@apache.org>.
chamikaramj merged PR #32841:
URL: https://github.com/apache/beam/pull/32841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Using single temp maven local repository for release validation tasks [beam]
Posted by "chamikaramj (via GitHub)" <gi...@apache.org>.
chamikaramj commented on code in PR #32841:
URL: https://github.com/apache/beam/pull/32841#discussion_r1806778762
##########
release/src/main/groovy/TestScripts.groovy:
##########
@@ -209,16 +220,17 @@ class TestScripts {
</profile>
</profiles>
</settings>
- """
- def cmd = "mvn ${args} -s ${settings.absolutePath} -Ptestrel -B"
- String path = System.getenv("PATH");
- // Set the path on jenkins executors to use a recent maven
- // MAVEN_HOME is not set on some executors, so default to 3.5.2
- String maven_home = System.getenv("MAVEN_HOME") ?: '/home/jenkins/tools/maven/apache-maven-3.5.4'
- println "Using maven ${maven_home}"
- def mvnPath = "${maven_home}/bin"
- def setPath = "export PATH=\"${mvnPath}:${path}\" && "
- return _execute(setPath + cmd)
+ """
+ }
+ def cmd = "mvn ${args} -s ${settings.absolutePath} -Ptestrel -B"
Review Comment:
Ack. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Using single temp maven local repository for release validation tasks [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32841:
URL: https://github.com/apache/beam/pull/32841#issuecomment-2420208843
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Using single temp maven local repository for release validation tasks [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32841:
URL: https://github.com/apache/beam/pull/32841#issuecomment-2420287321
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Using single temp maven local repository for release validation tasks [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #32841:
URL: https://github.com/apache/beam/pull/32841#issuecomment-2420071501
test run: https://github.com/apache/beam/actions/runs/11389484525/job/31688875732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org