You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by manuzhang <gi...@git.apache.org> on 2017/05/08 05:38:01 UTC

[GitHub] incubator-gearpump pull request #181: [GEARPUMP-305] Add Internals section t...

GitHub user manuzhang opened a pull request:

    https://github.com/apache/incubator-gearpump/pull/181

    [GEARPUMP-305] Add Internals section to docs

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the commit message is formatted like:
       `[GEARPUMP-<Jira issue #>] Meaningful description of pull request` 
     - [ ] Make sure tests pass via `sbt clean test`.
     - [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manuzhang/incubator-gearpump doc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-gearpump/pull/181.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #181
    
----
commit 6edd7a241ed3edec3f6acc0073e4586895753e46
Author: manuzhang <ow...@gmail.com>
Date:   2017-05-08T05:35:13Z

    [GEARPUMP-305] Add Internals section to docs

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #181: [GEARPUMP-305] Add Internals section to docs

Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/181
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump pull request #181: [GEARPUMP-305] Add Internals section t...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-gearpump/pull/181


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #181: [GEARPUMP-305] Add Internals section to docs

Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/181
  
    # [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/181?src=pr&el=h1) Report
    > Merging [#181](https://codecov.io/gh/apache/incubator-gearpump/pull/181?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/9798863753dac06077ce23bef5f451bf7fdca619?src=pr&el=desc) will **decrease** coverage by `0.01%`.
    > The diff coverage is `n/a`.
    
    
    
    ```diff
    @@            Coverage Diff             @@
    ##           master     #181      +/-   ##
    ==========================================
    - Coverage   71.63%   71.62%   -0.02%     
    ==========================================
      Files         191      191              
      Lines        6086     6086              
      Branches      527      527              
    ==========================================
    - Hits         4360     4359       -1     
    - Misses       1726     1727       +1
    ```
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---