You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2021/04/24 13:46:40 UTC

[GitHub] [ratis] softgitron opened a new pull request #468: Fix SonarQube issues in IOUtils

softgitron opened a new pull request #468:
URL: https://github.com/apache/ratis/pull/468


   ## What changes were proposed in this pull request?
   
   This PR fixes problems related by Sonar Qube including two NPE issues. Bellow more comprehensive list of changes:
   - Fix asIOException function NPE
   - Reaorganize readFully function for better readability
   - Change while-loop like for-loops to actual while-loops
   - Fix readObject function NPE
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/RATIS-1364
   
   ## How was this patch tested?
   
   Change has been tested using existing unit tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] szetszwo commented on pull request #468: Ratis 1364 Fix Sonar Qube issues in IOUtils

Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #468:
URL: https://github.com/apache/ratis/pull/468#issuecomment-827367546


   @softgitron , thanks for working on this!
   
   Please fix the NPE bugs but not changing code style (e.g. for-loop to while-loop).  We should avoid unnecessary changes such as code style changes or whitespace changes.  Some people may find for-loop better and some others may like while-loop more.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] softgitron commented on pull request #468: RATIS-1364 Fix Sonar Qube issues in IOUtils

Posted by GitBox <gi...@apache.org>.
softgitron commented on pull request #468:
URL: https://github.com/apache/ratis/pull/468#issuecomment-832076689


   > @softgitron , thanks for working on this!
   > 
   > Please fix the NPE bugs but not changing code style (e.g. for-loop to while-loop). We should avoid unnecessary changes such as code style changes or whitespace changes. Some people may find for-loop better and some others may like while-loop more.
   
   Understood! I see, these random fixes have become a bad habit for me. In some of my previous projects these kind of small fixes were endorsed by maintainers and because of that I still slip those in the PR. In this case fixes were made based on the SonarQube recommendations.
   
   I try to avoid this behavior with this project from now on.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] szetszwo merged pull request #468: RATIS-1364 Fix Sonar Qube issues in IOUtils

Posted by GitBox <gi...@apache.org>.
szetszwo merged pull request #468:
URL: https://github.com/apache/ratis/pull/468


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org