[jira] [Commented] (PHOENIX-4884) INSTR function should work seamlessly with literal and non-literal arguments

["Josh Elser (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-4884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598812#comment-16598812 ] 

Josh Elser commented on PHOENIX-4884:
-------------------------------------

[~sergey.soldatov] gave me the starting place for this fix. I expanded it a bit more and added some new test cases too.

> INSTR function should work seamlessly with literal and non-literal arguments
> ----------------------------------------------------------------------------
>
>                 Key: PHOENIX-4884
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4884
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Major
>             Fix For: 4.15.0, 5.1.0
>
>         Attachments: PHOENIX-4884.001.patch
>
>
> INSTR's documentation reads as though it should support an expression or a literal for either argument. At least, it doesn't say that it only supports one or the other.
> However, the implementation only handles the case of {{INSTR(expr, literal)}}. We can pretty easily make this better and work with any combination:
> e.g. {{INSTR(literal, expr)}}, {{INSTR(expr, expr)}}, {{INSTR(literal, literal)}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)