You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2014/11/26 17:44:06 UTC
[GitHub] couchdb-fauxton pull request: One_pane template should limit heade...
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/170
One_pane template should limit header width
This was added to fix an issue on the Databases page where the API Bar
was missing. It occurred because the <header> was filling up all
available space, taking it offscreen, thanks the #dashboard being
100%. I believe this is the only instance of the problem.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton missing-api-bar-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/170.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #170
----
commit 19ea4c57f1de8851e2766481ab8827dcbd6a1c25
Author: Benjamin Keen <be...@gmail.com>
Date: 2014-11-26T16:43:05Z
One_pane template should limit header width
This was added to fix an issue on the Databases page where the API Bar
was missing. It occurred because the <header> was filling up all
available space, taking it offscreen, thanks the #dashboard being
100%. I believe this is the only instance of the problem.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: One_pane template should limit heade...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/170#issuecomment-64694390
I just found another issue: https://cloudup.com/files/ijq57x-crsj/download
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: One_pane template should limit heade...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/170#issuecomment-64680351
Sure!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: One_pane template should limit heade...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/170#issuecomment-64679915
can you add a regression test so we are sure the api-url button is there and the bug does not come up again?
i think `waitForElementVisible` should work
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Layout templates should limit header...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/170#issuecomment-64731143
Sheesh, what a pain this ticket's been. I've removed the #dashboard 100% width due to the problems you spotted and solved it in another fashion: the main templates now explicitly set the width on the #dashboard via the existing `.window-resizeable-full` class. I haven't encountered any other problems with this solution, but take a look.
*** Note: Robert, if you spot any further problems with this ticket and it's holding you up, just remove the `#dashboard { width:100%; }` code - we'll discuss this later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: One_pane template should limit heade...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/170#issuecomment-64683984
@robertkowalski - added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Layout templates should limit header...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/170#issuecomment-64814928
yes!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Layout templates should limit header...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/170
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Layout templates should limit header...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/170#issuecomment-64782926
Oh wait! Let's talk! I am currently fixing all this stuff and removing it. see https://github.com/robertkowalski/couchdb-fauxton/commit/19d8b9e31b3859d44d51224d117c10c031dc1894 - if it is okay for you I would suggest to revert the change (we are buying temporary stability with flickering issues then) and assign me the ticket - as I am currently rewriting the way panes work I can take care of that. That was not really obvious to me yesterday when I found the bug, but as I see the workaround it is a thing which will get removed anyway around next week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Layout templates should limit header...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/170#issuecomment-64813390
No problem. So just to be clear, I'll scrap this ticket and put through a simple commit to remove the #dash 100%, correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---