You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/01 01:30:03 UTC

[GitHub] [kafka] rondagostino commented on a change in pull request #10008: MINOR: Remove ZK dependency from GroupCoordinator

rondagostino commented on a change in pull request #10008:
URL: https://github.com/apache/kafka/pull/10008#discussion_r567520074



##########
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##########
@@ -318,8 +318,9 @@ class KafkaServer(
 
         /* start group coordinator */
         // Hardcode Time.SYSTEM for now as some Streams tests fail otherwise, it would be good to fix the underlying issue
-        groupCoordinator = GroupCoordinator(config, zkClient, replicaManager, Time.SYSTEM, metrics)
-        groupCoordinator.startup()
+        groupCoordinator = GroupCoordinator(config, replicaManager, Time.SYSTEM, metrics)
+        groupCoordinator.startup(zkClient.getTopicPartitionCount(Topic.GROUP_METADATA_TOPIC_NAME).

Review comment:
       Yeah, it is difficult to justify beyond the fact that `startup()` exists -- maybe it deserves to be gotten rid of.  But that's perhaps a discussion for a separate ticket/PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org