[jira] [Commented] (AMBARI-18331) JMX metric retrieval method may unnecessarily refresh metrics at a high rate

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-18331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15471174#comment-15471174 ] 

Hadoop QA commented on AMBARI-18331:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12827366/AMBARI-18331.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in ambari-server:

                  org.apache.ambari.server.controller.metrics.JMXPropertyProviderTest
                  org.apache.ambari.server.controller.metrics.RestMetricsPropertyProviderTest

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/8598//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/8598//console

This message is automatically generated.

> JMX metric retrieval method may unnecessarily refresh metrics at a high rate
> ----------------------------------------------------------------------------
>
>                 Key: AMBARI-18331
>                 URL: https://issues.apache.org/jira/browse/AMBARI-18331
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-server
>    Affects Versions: 2.4.0
>            Reporter: Jonathan Hurley
>            Assignee: Jonathan Hurley
>             Fix For: trunk
>
>         Attachments: AMBARI-18331.patch
>
>
> In AMBARI-16913 we revised the JMX retrieval method to maintain an internal state of JMX metrics, with the retrieval taking place out of band of the actual jetty query requiring the metric.  However, each query will still generate a refresh request to the metric, regardless of it's current state.
> Recommend setting a TTL on a given metric such as 5 seconds, and only generate a new request for the metric if a TTL has expired, to avoid large amounts of repeat metrics collections in short windows.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)