You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by youngwookim <gi...@git.apache.org> on 2017/12/22 02:38:00 UTC
[GitHub] bigtop pull request #322: BIGTOP-2962: rpm and deb packaging for Presto
GitHub user youngwookim opened a pull request:
https://github.com/apache/bigtop/pull/322
BIGTOP-2962: rpm and deb packaging for Presto
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/youngwookim/bigtop BIGTOP-2962
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bigtop/pull/322.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #322
----
commit bc4098cdcaf2ad5870784c7fd4efa97ec85d26f8
Author: Youngwoo Kim <yw...@...>
Date: 2017-12-22T02:35:35Z
BIGTOP-2962: rpm and deb packaging for Presto
----
---
[GitHub] bigtop pull request #322: BIGTOP-2962: rpm and deb packaging for Presto
Posted by evans-ye <gi...@git.apache.org>.
Github user evans-ye commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/322#discussion_r158422686
--- Diff: bigtop-packages/src/common/presto/presto-server.svc ---
@@ -0,0 +1,70 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+TYPE="server"
+DAEMON="presto-${TYPE}"
+DESC="Presto ${TYPE}"
+EXEC_PATH="/usr/lib/presto/bin/launcher"
+SVC_USER="presto"
+WORKING_DIR="/usr/lib/presto"
+DAEMON_FLAGS="--launcher-config /usr/lib/presto/bin/launcher.properties --jvm-config /etc/presto/jvm.config --config /etc/presto/config.properties --data-dir /var/lib/presto/ --pid-file /var/run/presto/${DAEMON}.pid --launcher-log-file /var/log/presto/${DAEMON}.out --server-log-file /var/log/presto/${DAEMON}.log"
+CONF_DIR="/etc/presto"
+PIDFILE="/var/run/presto/${DAEMON}.pid"
+
+generate_start() {
+
+cat <<'__EOT__'
+start() {
+ # node.id
+ sed -i -e "s#ffffffff-ffff-ffff-ffff-ffffffffffff#$(cat /proc/sys/kernel/random/uuid)#" ${CONF_DIR}/node.properties
--- End diff --
The node ID will be regenerated whenever the daemon is started?
---
[GitHub] bigtop pull request #322: BIGTOP-2962: rpm and deb packaging for Presto
Posted by youngwookim <gi...@git.apache.org>.
Github user youngwookim commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/322#discussion_r158421600
--- Diff: bigtop-packages/src/common/presto/install_presto.sh ---
@@ -0,0 +1,209 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+set -e
+
+usage() {
+ echo "
+usage: $0 <options>
+ Required not-so-options:
+ --build-dir=DIR path to dist.dir
+ --source-dir=DIR path to package shared files dir
+ --prefix=PREFIX path to install into
+
+ Optional options:
+ --doc-dir=DIR path to install docs into [/usr/share/doc/presto]
+ --lib-dir=DIR path to install Presto home [/usr/lib/presto]
+ --installed-lib-dir=DIR path where lib-dir will end up on target system
+ --bin-dir=DIR path to install bins [/usr/bin]
+ ... [ see source for more similar options ]
+ "
+ exit 1
+}
+
+OPTS=$(getopt \
+ -n $0 \
+ -o '' \
+ -l 'prefix:' \
+ -l 'doc-dir:' \
+ -l 'lib-dir:' \
+ -l 'installed-lib-dir:' \
+ -l 'bin-dir:' \
+ -l 'source-dir:' \
+ -l 'build-dir:' -- "$@")
+
+if [ $? != 0 ] ; then
+ usage
+fi
+
+eval set -- "$OPTS"
+while true ; do
+ case "$1" in
+ --prefix)
+ PREFIX=$2 ; shift 2
+ ;;
+ --build-dir)
+ BUILD_DIR=$2 ; shift 2
+ ;;
+ --source-dir)
+ SOURCE_DIR=$2 ; shift 2
+ ;;
+ --doc-dir)
+ DOC_DIR=$2 ; shift 2
+ ;;
+ --lib-dir)
+ LIB_DIR=$2 ; shift 2
+ ;;
+ --installed-lib-dir)
+ INSTALLED_LIB_DIR=$2 ; shift 2
+ ;;
+ --bin-dir)
+ BIN_DIR=$2 ; shift 2
+ ;;
+ --)
+ shift ; break
+ ;;
+ *)
+ echo "Unknown option: $1"
+ usage
+ exit 1
+ ;;
+ esac
+done
+
+for var in PREFIX BUILD_DIR SOURCE_DIR; do
+ if [ -z "$(eval "echo \$$var")" ]; then
+ echo Missing param: $var
+ usage
+ fi
+done
+
+if [ -f "$SOURCE_DIR/bigtop.bom" ]; then
+ . $SOURCE_DIR/bigtop.bom
+fi
+
+MAN_DIR=${MAN_DIR:-/usr/share/man/man1}
+DOC_DIR=${DOC_DIR:-/usr/share/doc/presto}
+LIB_DIR=${LIB_DIR:-/usr/lib/presto}
+VAR_DIR=${VAR_DIR:-/var/lib/presto}
+LOG_DIR=${LOG_DIR:-/var/log/presto}
+RUN_DIR=${RUN_DIR:-/var/run/presto}
+INSTALLED_LIB_DIR=${INSTALLED_LIB_DIR:-/usr/lib/presto}
+BIN_DIR=${BIN_DIR:-/usr/bin}
+CONF_DIR=${CONF_DIR:-/etc/presto}
+CONF_DIST_DIR=${CONF_DIST_DIR:-/etc/presto.dist}
+DEFAULT_DIR=${DEFAULT_DIR:-/etc/default}
+
+install -d -m 0755 $PREFIX/$CONF_DIST_DIR
+install -d -m 0755 $PREFIX/$LIB_DIR
+install -d -m 0755 $PREFIX/$LIB_DIR/lib
+install -d -m 0755 $PREFIX/$LIB_DIR/bin
+install -d -m 0755 $PREFIX/$LIB_DIR/var
+install -d -m 0755 $PREFIX/$LIB_DIR/plugin
+install -d -m 0755 $PREFIX/$DOC_DIR
+install -d -m 0755 $PREFIX/$VAR_DIR
+install -d -m 0755 $PREFIX/$LOG_DIR
+install -d -m 0755 $PREFIX/$RUN_DIR
+install -d -m 0755 $PREFIX/$DEFAULT_DIR
+
+cp -ra ${BUILD_DIR}/* $PREFIX/$LIB_DIR/
+mv $PREFIX/$LIB_DIR/docs/* $PREFIX/$DOC_DIR/
+
+chmod +x $PREFIX/$LIB_DIR/bin/presto
+
+install -d -m 0755 $PREFIX/$CONF_DIST_DIR
+install -d -m 0755 $PREFIX/$CONF_DIST_DIR/catalog
+
+cat > $PREFIX/$CONF_DIST_DIR/node.properties <<EOF
+node.environment=production
+node.id=ffffffff-ffff-ffff-ffff-ffffffffffff
+node.data-dir=/var/lib/presto/
+EOF
+
+cat > $PREFIX/$CONF_DIST_DIR/jvm.config <<EOF
+-server
+-Xmx1G
+-XX:+UseG1GC
+-XX:G1HeapRegionSize=32M
+-XX:+UseGCOverheadLimit
+-XX:+ExplicitGCInvokesConcurrent
+-XX:+HeapDumpOnOutOfMemoryError
+-XX:+ExitOnOutOfMemoryError
+-DHADOOP_USER_NAME=hive
--- End diff --
'hive' is a HDFS username for Presto server. if we specify the username, Presto server will access HDFS as user of presto process. IMHO, if users don't use Kerberos, 'hive' is appropriate one.
https://prestodb.io/docs/current/connector/hive.html
---
[GitHub] bigtop pull request #322: BIGTOP-2962: rpm and deb packaging for Presto
Posted by evans-ye <gi...@git.apache.org>.
Github user evans-ye commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/322#discussion_r158420536
--- Diff: bigtop-packages/src/common/presto/install_presto.sh ---
@@ -0,0 +1,209 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+set -e
+
+usage() {
+ echo "
+usage: $0 <options>
+ Required not-so-options:
+ --build-dir=DIR path to dist.dir
+ --source-dir=DIR path to package shared files dir
+ --prefix=PREFIX path to install into
+
+ Optional options:
+ --doc-dir=DIR path to install docs into [/usr/share/doc/presto]
+ --lib-dir=DIR path to install Presto home [/usr/lib/presto]
+ --installed-lib-dir=DIR path where lib-dir will end up on target system
+ --bin-dir=DIR path to install bins [/usr/bin]
+ ... [ see source for more similar options ]
+ "
+ exit 1
+}
+
+OPTS=$(getopt \
+ -n $0 \
+ -o '' \
+ -l 'prefix:' \
+ -l 'doc-dir:' \
+ -l 'lib-dir:' \
+ -l 'installed-lib-dir:' \
+ -l 'bin-dir:' \
+ -l 'source-dir:' \
+ -l 'build-dir:' -- "$@")
+
+if [ $? != 0 ] ; then
+ usage
+fi
+
+eval set -- "$OPTS"
+while true ; do
+ case "$1" in
+ --prefix)
+ PREFIX=$2 ; shift 2
+ ;;
+ --build-dir)
+ BUILD_DIR=$2 ; shift 2
+ ;;
+ --source-dir)
+ SOURCE_DIR=$2 ; shift 2
+ ;;
+ --doc-dir)
+ DOC_DIR=$2 ; shift 2
+ ;;
+ --lib-dir)
+ LIB_DIR=$2 ; shift 2
+ ;;
+ --installed-lib-dir)
+ INSTALLED_LIB_DIR=$2 ; shift 2
+ ;;
+ --bin-dir)
+ BIN_DIR=$2 ; shift 2
+ ;;
+ --)
+ shift ; break
+ ;;
+ *)
+ echo "Unknown option: $1"
+ usage
+ exit 1
+ ;;
+ esac
+done
+
+for var in PREFIX BUILD_DIR SOURCE_DIR; do
+ if [ -z "$(eval "echo \$$var")" ]; then
+ echo Missing param: $var
+ usage
+ fi
+done
+
+if [ -f "$SOURCE_DIR/bigtop.bom" ]; then
+ . $SOURCE_DIR/bigtop.bom
+fi
+
+MAN_DIR=${MAN_DIR:-/usr/share/man/man1}
+DOC_DIR=${DOC_DIR:-/usr/share/doc/presto}
+LIB_DIR=${LIB_DIR:-/usr/lib/presto}
+VAR_DIR=${VAR_DIR:-/var/lib/presto}
+LOG_DIR=${LOG_DIR:-/var/log/presto}
+RUN_DIR=${RUN_DIR:-/var/run/presto}
+INSTALLED_LIB_DIR=${INSTALLED_LIB_DIR:-/usr/lib/presto}
+BIN_DIR=${BIN_DIR:-/usr/bin}
+CONF_DIR=${CONF_DIR:-/etc/presto}
+CONF_DIST_DIR=${CONF_DIST_DIR:-/etc/presto.dist}
+DEFAULT_DIR=${DEFAULT_DIR:-/etc/default}
+
+install -d -m 0755 $PREFIX/$CONF_DIST_DIR
+install -d -m 0755 $PREFIX/$LIB_DIR
+install -d -m 0755 $PREFIX/$LIB_DIR/lib
+install -d -m 0755 $PREFIX/$LIB_DIR/bin
+install -d -m 0755 $PREFIX/$LIB_DIR/var
+install -d -m 0755 $PREFIX/$LIB_DIR/plugin
+install -d -m 0755 $PREFIX/$DOC_DIR
+install -d -m 0755 $PREFIX/$VAR_DIR
+install -d -m 0755 $PREFIX/$LOG_DIR
+install -d -m 0755 $PREFIX/$RUN_DIR
+install -d -m 0755 $PREFIX/$DEFAULT_DIR
+
+cp -ra ${BUILD_DIR}/* $PREFIX/$LIB_DIR/
+mv $PREFIX/$LIB_DIR/docs/* $PREFIX/$DOC_DIR/
+
+chmod +x $PREFIX/$LIB_DIR/bin/presto
+
+install -d -m 0755 $PREFIX/$CONF_DIST_DIR
+install -d -m 0755 $PREFIX/$CONF_DIST_DIR/catalog
+
+cat > $PREFIX/$CONF_DIST_DIR/node.properties <<EOF
+node.environment=production
+node.id=ffffffff-ffff-ffff-ffff-ffffffffffff
+node.data-dir=/var/lib/presto/
+EOF
+
+cat > $PREFIX/$CONF_DIST_DIR/jvm.config <<EOF
+-server
+-Xmx1G
+-XX:+UseG1GC
+-XX:G1HeapRegionSize=32M
+-XX:+UseGCOverheadLimit
+-XX:+ExplicitGCInvokesConcurrent
+-XX:+HeapDumpOnOutOfMemoryError
+-XX:+ExitOnOutOfMemoryError
+-DHADOOP_USER_NAME=hive
--- End diff --
Is it always should be hive?
---