You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Savalek <gi...@git.apache.org> on 2018/07/26 15:10:27 UTC
[GitHub] zeppelin pull request #3099: [ZEPPELIN-3665] fix notebook name
GitHub user Savalek opened a pull request:
https://github.com/apache/zeppelin/pull/3099
[ZEPPELIN-3665] fix notebook name
### What is this PR for?
Name of notebook incorrectly displayed due to text direction.
Bug Fix
### What is the Jira issue?
[ZEPPELIN-3665](https://issues.apache.org/jira/browse/ZEPPELIN-3665)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3665
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3099.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3099
----
commit f59f09e1edf171e3cffc5235922b95490d59bc59
Author: Savalek <de...@...>
Date: 2018-07-26T14:58:53Z
[ZEPPELIN-3665] fix notebook name
----
---
[GitHub] zeppelin pull request #3099: [ZEPPELIN-3665] fix notebook name
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3099
---
[GitHub] zeppelin pull request #3099: [ZEPPELIN-3665] fix notebook name
Posted by Savalek <gi...@git.apache.org>.
Github user Savalek closed the pull request at:
https://github.com/apache/zeppelin/pull/3099
---
[GitHub] zeppelin pull request #3099: [ZEPPELIN-3665] fix notebook name
Posted by Savalek <gi...@git.apache.org>.
GitHub user Savalek reopened a pull request:
https://github.com/apache/zeppelin/pull/3099
[ZEPPELIN-3665] fix notebook name
### What is this PR for?
Name of notebook incorrectly displayed due to text direction.
Bug Fix
### What is the Jira issue?
[ZEPPELIN-3665](https://issues.apache.org/jira/browse/ZEPPELIN-3665)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3665
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3099.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3099
----
commit f59f09e1edf171e3cffc5235922b95490d59bc59
Author: Savalek <de...@...>
Date: 2018-07-26T14:58:53Z
[ZEPPELIN-3665] fix notebook name
commit cd77f59e21ab1f324fa2bb7c5472f5c537b505bc
Author: Savalek <de...@...>
Date: 2018-07-27T08:05:16Z
[ZEPPELIN-3665] fix notebook name. add
'unicode-bidi: plaintext'
----
---
[GitHub] zeppelin issue #3099: [ZEPPELIN-3665] fix notebook name
Posted by Savalek <gi...@git.apache.org>.
Github user Savalek commented on the issue:
https://github.com/apache/zeppelin/pull/3099
@felixcheung, i think no. `notebook.css` the only place where used `direction: rtl;`.
---
[GitHub] zeppelin issue #3099: [ZEPPELIN-3665] fix notebook name
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3099
it might help if you include a before / after screen shots?
---
[GitHub] zeppelin issue #3099: [ZEPPELIN-3665] fix notebook name
Posted by Tagar <gi...@git.apache.org>.
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3099
If there is a very long "folder/subfolder1/subfolder" part, wouldn't this change always to
display only "folder/subfolder1/subfolder..." and not a notebook name?
---
[GitHub] zeppelin issue #3099: [ZEPPELIN-3665] fix notebook name
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3099
cool
merging if no more comment
---
[GitHub] zeppelin issue #3099: [ZEPPELIN-3665] fix notebook name
Posted by Savalek <gi...@git.apache.org>.
Github user Savalek commented on the issue:
https://github.com/apache/zeppelin/pull/3099
@Tagar, thanks! I missed it. I added a property "unicode-bidi: plaintext;". Now it should work fine.
---
[GitHub] zeppelin issue #3099: [ZEPPELIN-3665] fix notebook name
Posted by Savalek <gi...@git.apache.org>.
Github user Savalek commented on the issue:
https://github.com/apache/zeppelin/pull/3099
@felixcheung, I added scren shots.
---