You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/02/20 11:01:13 UTC
[GitHub] sijie commented on a change in pull request #3625: [Issue
#3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic
creation
sijie commented on a change in pull request #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation
URL: https://github.com/apache/pulsar/pull/3625#discussion_r258431145
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -398,6 +398,18 @@ protected void internalCreatePartitionedTopic(int numPartitions, boolean authori
}
}
+ protected void internalCreateNonPartitionedTopic(boolean authoritative) {
+ validateAdminAccessForTenant(topicName.getTenant());
+
+ try {
+ PersistentTopic topic = (PersistentTopic) getOrCreateTopic(topicName);
+ //...
Review comment:
what is this for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services