You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/23 07:48:35 UTC

[GitHub] [apisix] imjoey commented on pull request #2279: feat: Add labels for upstream object

imjoey commented on pull request #2279:
URL: https://github.com/apache/apisix/pull/2279#issuecomment-697196007


   > @imjoey One thing confuses me that the labels field is attached on the whole `upstream` object, It's closer to the labels on Kubernetes Service, not the Pod, and labels on Pod are more pragmatic, so what about attaching labels for each node in this upstream, with this support, we can group the nodes by labels, and in turn implementing some features like blue green release, canary release or other route rules.
   
   Hi @tokers , thanks for your feedback. I guess labels could be very useful for every single object in APISIX. While currently `Node` is not an independent object so we are not able to mange the labels attached. We may refer to the existing field named `metadata` for your requirements.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org