[GitHub] [james-project] Arsnael commented on a diff in pull request #1109: JAMES-3711 Cleanup the OpenSearch migration

[GitBox <gi...@apache.org>]

Arsnael commented on code in PR #1109:
URL: https://github.com/apache/james-project/pull/1109#discussion_r940846967


##########
server/apps/distributed-pop3-app/README.adoc:
##########
@@ -14,14 +14,12 @@ Firstly, create your own user network on Docker for the James environment:
 Third party compulsory dependencies:
 
  * Cassandra 3.11.10
- * ElasticSearch 7.10.2

Review Comment:
   we don't need OS for distributed pop 3?



##########
server/apps/distributed-pop3-app/sample-configuration/elasticsearch.properties:
##########
@@ -1,83 +0,0 @@
-#  Licensed to the Apache Software Foundation (ASF) under one
-#  or more contributor license agreements.  See the NOTICE file
-#  distributed with this work for additional information
-#  regarding copyright ownership.  The ASF licenses this file
-#  to you under the Apache License, Version 2.0 (the
-#  "License"); you may not use this file except in compliance
-#  with the License.  You may obtain a copy of the License at
-#
-#    http://www.apache.org/licenses/LICENSE-2.0
-#
-#  Unless required by applicable law or agreed to in writing,
-#  software distributed under the License is distributed on an
-#  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-#  KIND, either express or implied.  See the License for the
-#  specific language governing permissions and limitations
-#  under the License.
-
-#  This template file can be used as example for James Server configuration
-#  DO NOT USE IT AS SUCH AND ADAPT IT TO YOUR NEEDS
-
-# Configuration file for ElasticSearch

Review Comment:
   No replacement of this file to opensearch.properties for distributed pop3?



##########
backends-common/opensearch/src/test/resources/auth-es/README.md:
##########
@@ -3,9 +3,12 @@
 ### nginx-conf
 
 Contains nginx configuration files:
- - reverse_elasticsearch.conf: allow nginx to be the proxy connecting to ElasticSearch
+ - reverse_elasticsearch.conf: allow nginx to be the proxy connecting to OpenSearch
  - passwd: Nginx credentials file store, each record follows the format: `username:encrypted-password`
 
+TODO This set up is inherited from ElasticSearch where the security plugin was proprietary and this was our only way to 
+test things like SSL, auth. Now that we use OpenSearch we could instead rely on OpenSearch native features.

Review Comment:
   :+1: 



##########
server/apps/cassandra-app/src/test/java/org/apache/james/ESReporterTest.java:
##########
@@ -60,10 +60,10 @@
 
 class ESReporterTest {

Review Comment:
   Does this test should still exist? It's disabled, on cassandra app, related to export metrics to ES and not opensearch... I think we can get rid of it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org