[GitHub] [drill] jnturton commented on a change in pull request #2429: DRILL-8107: Hadoop2 backport Maven profile

[GitBox <gi...@apache.org>]

jnturton commented on a change in pull request #2429:
URL: https://github.com/apache/drill/pull/2429#discussion_r786005734



##########
File path: exec/jdbc-all/pom.xml
##########
@@ -874,6 +874,42 @@
         </plugins>
       </build>
     </profile>
+    <profile>
+      <id>hadoop-2</id>
+      <build>
+      <plugins>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-enforcer-plugin</artifactId>
+          <executions>
+            <execution>
+              <id>enforce-jdbc-jar-compactness</id>
+              <goals>
+                <goal>enforce</goal>
+              </goals>
+              <phase>verify</phase>
+              <configuration>
+                <rules>
+                  <requireFilesSize>
+                    <message>
+                      The file drill-jdbc-all-${project.version}.jar is outside the expected size range.
+                      This is likely due to you adding new dependencies to a java-exec and not updating the excludes in this module. This is important as it minimizes the size of the dependency of Drill application users.
+                    </message>
+                    <maxsize>47600000</maxsize>

Review comment:
       Sounds like something that we should make a property anyway.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org