[jira] [Commented] (FINERACT-1016) Flaky RecurringDepositTest.testPrematureClosureAmountWithPenalInterestTillPrematureWithdrawal_With_360_Days()

["Michael Vorburger (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FINERACT-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17224092#comment-17224092 ] 

Michael Vorburger commented on FINERACT-1016:
---------------------------------------------

FYI FINERACT-1248 has a new RecurringDepositTest failure.

> Flaky RecurringDepositTest.testPrematureClosureAmountWithPenalInterestTillPrematureWithdrawal_With_360_Days()
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: FINERACT-1016
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1016
>             Project: Apache Fineract
>          Issue Type: Sub-task
>            Reporter: Michael Vorburger
>            Assignee: Petri Tuomola
>            Priority: Blocker
>             Fix For: 1.4.0
>
>
> See comments in FINERACT-855 from yesterday and today re. testPrematureClosureAmountWithPenalInterestTillPrematureWithdrawal_With_360_Days():
> {code:java}org.apache.fineract.integrationtests.RecurringDepositTest > testPrematureClosureAmountWithPenalInterestTillPrematureWithdrawal_With_360_Days FAILED
>     java.lang.AssertionError: Verifying Pre-Closure maturity amount expected:<4005.0> but was:<4006.0>
>         at org.junit.Assert.fail(Assert.java:89)
>         at org.junit.Assert.failNotEquals(Assert.java:835)
>         at org.junit.Assert.assertEquals(Assert.java:120)
>         at org.apache.fineract.integrationtests.RecurringDepositTest.testPrematureClosureAmountWithPenalInterestTillPrematureWithdrawal_With_360_Days(RecurringDepositTest.java:2161){code}
> Because this problem probably actually has nothing at all to do with the testRecurringDepositAccountWithClosureTypeTransferToSavings_WITH_HOLD_TAX() failure which FINERACT-855 was originally about, so let's track this separately here.
> This testPrematureClosureAmountWithPenalInterestTillPrematureWithdrawal_With_360_Days() failure today seems to have nothing to do with the Job Scheduler (for once), but appears to be some date related mess.
> That test today right for me reliably fails locally, but when I change my system date back a few days to late May, then it passes. So either the test, or worse even the actual logic being tested, has some bug in date handling.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)