You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/04/24 16:46:00 UTC

[jira] [Commented] (IMPALA-9631) Import HLL functionality from DataSketches

    [ https://issues.apache.org/jira/browse/IMPALA-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17091723#comment-17091723 ] 

ASF subversion and git services commented on IMPALA-9631:
---------------------------------------------------------

Commit 9a3108709bf9cc11f00b97e966d1514bd59b34c8 in impala's branch refs/heads/master from Gabor Kaszab
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=9a31087 ]

IMPALA-9631: Import HLL functionality from DataSketches

This patch imports the functionality needed for HLL approximate
algorithm from Apache DataSketches. I decided to copy the necessary
files into be/src/thirdparty/datasketches. Note, that the original
structure of files was changed during this process as originally hll/
and common/ libraries were both affected but I copied these into the
same directory so that Impala can compile them without rewriting the
include paths in the files themselves. Also note, that not the whole
common/ directory was copied just the files needed for HLL.

The git hash of the snapshot I used as a source for the files:
a6265b307a03085abe26c20413fdbf7d7a5eaf29

Browse the source files here:
https://github.com/apache/incubator-datasketches-cpp

Change-Id: I8ca8e77dcbb6b6c3b1e3bca7ab57cb7d3c018bbf
Reviewed-on: http://gerrit.cloudera.org:8080/15746
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Import HLL functionality from DataSketches
> ------------------------------------------
>
>                 Key: IMPALA-9631
>                 URL: https://issues.apache.org/jira/browse/IMPALA-9631
>             Project: IMPALA
>          Issue Type: New Feature
>          Components: Infrastructure
>            Reporter: Gabor Kaszab
>            Assignee: Gabor Kaszab
>            Priority: Major
>
> Import HLL from DataSketches into Impala:
> https://github.com/apache/incubator-datasketches-cpp/tree/master/hll/include
> Include it in the build system and make sure that hll.hpp can be included into Impala source files and also verify with tests that the basic functionality such as sketch creation, update() and get_result() can be invoked.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org