You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Kirby1337 <gi...@git.apache.org> on 2014/05/19 17:46:32 UTC

[GitHub] thrift pull request: THRIFT-2522 TypeScript extension for Thrift C...

GitHub user Kirby1337 opened a pull request:

    https://github.com/apache/thrift/pull/124

    THRIFT-2522 TypeScript extension for Thrift Compiler

    Adds the possibility to generate TypeScript Definition Files in addition to the generated JavaScript code (new parameter 'ts').
    Supports JQuery, NodeJS support will come soon.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Kirby1337/thrift typescript

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/124.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #124
    
----
commit ada1016fdd6408694f9b82d5de8c1fbbf8d8a528
Author: Pascal Schweizer <pa...@hispeed.ch>
Date:   2014-03-21T16:18:59Z

    THRIFT-2522 TypeScript extension for Thrift Compiler

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #124: THRIFT-2522 TypeScript extension for Thrift Compiler

Posted by kamek-pf <gi...@git.apache.org>.
Github user kamek-pf commented on the issue:

    https://github.com/apache/thrift/pull/124
  
    Apparently :p
    It generates definition files that matches the `js` target, but it looks like there is no equivalent for `js:node`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2522 TypeScript extension for Thrift C...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/124


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #124: THRIFT-2522 TypeScript extension for Thrift Compiler

Posted by beejjacobs <gi...@git.apache.org>.
Github user beejjacobs commented on the issue:

    https://github.com/apache/thrift/pull/124
  
    > NodeJS support will come soon
    
    Any update on NodeJS support?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #124: THRIFT-2522 TypeScript extension for Thrift Compiler

Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the issue:

    https://github.com/apache/thrift/pull/124
  
    We have a ts target?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2522 TypeScript extension for Thrift C...

Posted by henrique <gi...@git.apache.org>.
Github user henrique commented on the pull request:

    https://github.com/apache/thrift/pull/124#issuecomment-43534405
  
    Thanks a lot Pascal!
    It's looking good. I have also added a sub-section to the lib/js/README.md, please fell free to add more info or a simple example of usage there. Looking forward to seeing the node.js support ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #124: THRIFT-2522 TypeScript extension for Thrift Compiler

Posted by kamek-pf <gi...@git.apache.org>.
Github user kamek-pf commented on the issue:

    https://github.com/apache/thrift/pull/124
  
    I was wondering the same thing.
    For now I'm writting the libdefs myself, but it would be a nice addition for sure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---