You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/07/08 02:10:44 UTC
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5624: Excluding eclipse project meta files (#5623)
Jackie-Jiang commented on a change in pull request #5624:
URL: https://github.com/apache/incubator-pinot/pull/5624#discussion_r451241624
##########
File path: pom.xml
##########
@@ -1553,8 +1553,11 @@
<exclude>**/*.properties</exclude>
<!-- IDE files -->
- <exclude>**/*.iml</exclude>
-
+ <exclude>**/*.iml</exclude>
+ <!-- Eclipse IDE files -->
+ <exclude>**/*.project</exclude>
+ <exclude>**/*.classpath</exclude>
+ <exclude>**/*.prefs</exclude>
<!-- Top level -->
Review comment:
(nit) add an empty line for readability
##########
File path: pom.xml
##########
@@ -1553,8 +1553,11 @@
<exclude>**/*.properties</exclude>
<!-- IDE files -->
- <exclude>**/*.iml</exclude>
-
+ <exclude>**/*.iml</exclude>
Review comment:
The indentation doesn't seem right
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org