You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/11/24 18:24:02 UTC

[GitHub] [kafka] jsancio opened a new pull request #11536: MINOR; Update merge script to work against Python3

jsancio opened a new pull request #11536:
URL: https://github.com/apache/kafka/pull/11536


   Made the following changes so that it works in Python3:
   
   1. Use `print()` instead of `print`
   2. Use urllib instead of urllib2
   3. Decode all of the cmd outputs from bynary to string using UTF-8
   4. Use `input` instead of `raw_input`
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jsancio closed pull request #11536: MINOR; Update merge script to work against Python3

Posted by GitBox <gi...@apache.org>.
jsancio closed pull request #11536:
URL: https://github.com/apache/kafka/pull/11536


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jsancio closed pull request #11536: MINOR; Update merge script to work against Python3

Posted by GitBox <gi...@apache.org>.
jsancio closed pull request #11536:
URL: https://github.com/apache/kafka/pull/11536


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jsancio commented on pull request #11536: MINOR; Update merge script to work against Python3

Posted by GitBox <gi...@apache.org>.
jsancio commented on pull request #11536:
URL: https://github.com/apache/kafka/pull/11536#issuecomment-991216638


   Merged as https://github.com/apache/kafka/commit/0c01ab67a034a9454fdd1e0c791c56c5466d9ff4


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jsancio commented on pull request #11536: MINOR; Update merge script to work against Python3

Posted by GitBox <gi...@apache.org>.
jsancio commented on pull request #11536:
URL: https://github.com/apache/kafka/pull/11536#issuecomment-991143098


   @dajac I made some changes after you reviewed. Does it LGTM?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jsancio edited a comment on pull request #11536: MINOR; Update merge script to work against Python3

Posted by GitBox <gi...@apache.org>.
jsancio edited a comment on pull request #11536:
URL: https://github.com/apache/kafka/pull/11536#issuecomment-991143098


   @dajac I made some changes after you reviewed. Does it look good to you?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jsancio commented on pull request #11536: MINOR; Update merge script to work against Python3

Posted by GitBox <gi...@apache.org>.
jsancio commented on pull request #11536:
URL: https://github.com/apache/kafka/pull/11536#issuecomment-991216638


   Merged as https://github.com/apache/kafka/commit/0c01ab67a034a9454fdd1e0c791c56c5466d9ff4


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org