[GitHub] spark pull request #15074: [SPARK-17520] Implement a better __eq__ for Spars...

[gglanzani <gi...@git.apache.org>]

Github user gglanzani commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15074#discussion_r116300138
  
    --- Diff: python/pyspark/mllib/linalg/__init__.py ---
    @@ -1296,9 +1296,19 @@ def asML(self):
             return newlinalg.SparseMatrix(self.numRows, self.numCols, self.colPtrs, self.rowIndices,
                                           self.values, self.isTransposed)
     
    -    # TODO: More efficient implementation:
         def __eq__(self, other):
    -        return np.all(self.toArray() == other.toArray())
    +        if ((type(other) is not type(self)) or
    --- End diff --
    
    Ok. If this is the case then the `__eq__` method of the `DenseMatrix` class is also in trouble, as it returns `False` when they're not both `DenseMatrix` classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org