You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/14 17:18:16 UTC
[GitHub] [tvm] mehrdadh opened a new pull request, #11016: [Hexagon] Add test for registered schedules
mehrdadh opened a new pull request, #11016:
URL: https://github.com/apache/tvm/pull/11016
This PR adds test for registered schedules on hexagon target. Follow up to this PR: https://github.com/apache/tvm/pull/10919
cc @kparzysz-quic @csullivan @Lunderberg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on a diff in pull request #11016: [Hexagon] Add test for registered schedules
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on code in PR #11016:
URL: https://github.com/apache/tvm/pull/11016#discussion_r852235645
##########
tests/python/contrib/test_hexagon/test_batch_matmul.py:
##########
@@ -0,0 +1,138 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
makes sense. Moved them to sub-directories.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on a diff in pull request #11016: [Hexagon] Add test for registered schedules
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on code in PR #11016:
URL: https://github.com/apache/tvm/pull/11016#discussion_r852218603
##########
tests/scripts/task_build_hexagon_api.sh:
##########
@@ -19,8 +19,18 @@
set -e
set -u
+use_cache=false
+if [ $# -ge 1 ] && [[ "$1" == "--use-cache" ]]; then
+ use_cache=true
+ shift 1
+fi
+
Review Comment:
Unrelated to this PR but useful change for development. I could send a separate PR if you suggest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh merged pull request #11016: [Hexagon] Add test for registered schedules
Posted by GitBox <gi...@apache.org>.
mehrdadh merged PR #11016:
URL: https://github.com/apache/tvm/pull/11016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #11016: [Hexagon] Add test for registered schedules
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on PR #11016:
URL: https://github.com/apache/tvm/pull/11016#issuecomment-1099434048
@farshidsp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on a diff in pull request #11016: [Hexagon] Add test for registered schedules
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on code in PR #11016:
URL: https://github.com/apache/tvm/pull/11016#discussion_r852218129
##########
src/runtime/hexagon/rpc/hexagon/rpc_server.cc:
##########
@@ -41,7 +41,7 @@ extern "C" {
#include "hexagon_rpc.h"
// TODO(mehrdadh): make this configurable.
-#define TVM_HEXAGON_RPC_BUFF_SIZE_BYTES 2 * 1024 * 1024
+#define TVM_HEXAGON_RPC_BUFF_SIZE_BYTES 5 * 1024 * 1024
Review Comment:
yeah makes sense. Waiting for https://github.com/apache/tvm/pull/11022 to merge and then will rebase and fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on a diff in pull request #11016: [Hexagon] Add test for registered schedules
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on code in PR #11016:
URL: https://github.com/apache/tvm/pull/11016#discussion_r852217674
##########
python/tvm/script/tir/__init__.pyi:
##########
@@ -226,6 +226,7 @@ def alloc_buffer(
"""
special_stmt - Reads/Writes
"""
+
Review Comment:
This is done by the clang format tool.
##########
python/tvm/script/tir/__init__.pyi:
##########
@@ -337,6 +338,7 @@ def Assert(condition: Union[PrimExpr, builtins.bool], message: str) -> PrimExpr:
"""
Scope handler - Loops
"""
+
Review Comment:
same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] csullivan commented on a diff in pull request #11016: [Hexagon] Add test for registered schedules
Posted by GitBox <gi...@apache.org>.
csullivan commented on code in PR #11016:
URL: https://github.com/apache/tvm/pull/11016#discussion_r850677956
##########
python/tvm/script/tir/__init__.pyi:
##########
@@ -226,6 +226,7 @@ def alloc_buffer(
"""
special_stmt - Reads/Writes
"""
+
Review Comment:
```suggestion
```
##########
tests/python/contrib/test_hexagon/test_batch_matmul.py:
##########
@@ -0,0 +1,138 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Should we move these tests to an `topi/` subdirectory? Thinking about how we might want the directory structure. These are generic functionality tests, but soon we'll have tests for some of the same operators which utilize more complex scheduling. It would be nice to have these located in separate directories.
##########
python/tvm/script/tir/__init__.pyi:
##########
@@ -337,6 +338,7 @@ def Assert(condition: Union[PrimExpr, builtins.bool], message: str) -> PrimExpr:
"""
Scope handler - Loops
"""
+
Review Comment:
```suggestion
```
##########
tests/scripts/task_build_hexagon_api.sh:
##########
@@ -19,8 +19,18 @@
set -e
set -u
+use_cache=false
+if [ $# -ge 1 ] && [[ "$1" == "--use-cache" ]]; then
+ use_cache=true
+ shift 1
+fi
+
Review Comment:
Unrelated?
##########
src/runtime/hexagon/rpc/hexagon/rpc_server.cc:
##########
@@ -41,7 +41,7 @@ extern "C" {
#include "hexagon_rpc.h"
// TODO(mehrdadh): make this configurable.
-#define TVM_HEXAGON_RPC_BUFF_SIZE_BYTES 2 * 1024 * 1024
+#define TVM_HEXAGON_RPC_BUFF_SIZE_BYTES 5 * 1024 * 1024
Review Comment:
Looking at the TODO above, should we make this configurable now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org