[jira] [Updated] (HIVE-7420) Parameterize tests for HCatalog Pig interfaces for testing against all storage formats

["Carl Steinbach (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-7420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl Steinbach updated HIVE-7420:
---------------------------------

    Status: Open  (was: Patch Available)

Hi [~davidzchen], I left some comments on reviewboard, but also want to mention a couple issues here on JIRA. Please excuse the bullet points:
* The automated tests flagged failures in TestHCatLoader, TestHCatLoaderComplexSchema, TestHCatStorer, and TestHCatStorerMulti. We can't commit this patch until these test failures are resolved.
* This patch adds support for disabling all of the test methods in a particular testcase on a per-storageformat basis, but I think we really need the ability to disable individual test methods on a per-storageformat basis. It should be possible to do this by maintaining a Map<function_name, List<disabled_test_methods>> and using reflection to find the name of test method.
* For parameterized tests that fail, JUnit reports the parameter index, but not the actual parameter values (see report above). The latter would be a lot nicer. There's a [JUnitParams|https://github.com/Pragmatists/junitparams] project on Github that doesn't suck (according to the author), and which I think may report the actual parameter values as opposed to the parameter indexes. If you have time please take a look at this and see if it's worth using here.

> Parameterize tests for HCatalog Pig interfaces for testing against all storage formats
> --------------------------------------------------------------------------------------
>
>                 Key: HIVE-7420
>                 URL: https://issues.apache.org/jira/browse/HIVE-7420
>             Project: Hive
>          Issue Type: Sub-task
>          Components: HCatalog
>            Reporter: David Chen
>            Assignee: David Chen
>         Attachments: HIVE-7420-without-HIVE-7457.2.patch, HIVE-7420-without-HIVE-7457.3.patch, HIVE-7420.1.patch, HIVE-7420.2.patch, HIVE-7420.3.patch
>
>
> Currently, HCatalog tests only test against RCFile with a few testing against ORC. The tests should be covering other Hive storage formats as well.
> HIVE-7286 turns HCatMapReduceTest into a test fixture that can be run with all Hive storage formats and with that patch, all test suites built on HCatMapReduceTest are running and passing against Sequence File, Text, and ORC in addition to RCFile.
> Similar changes should be made to make the tests for HCatLoader and HCatStorer generic so that they can be run against all Hive storage formats.



--
This message was sent by Atlassian JIRA
(v6.2#6252)