You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/02/11 00:36:05 UTC
Review Request 43441: Update allocator tests to pass shared_ptrs to
'StartSlave'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43441/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske and Artem Harutyunyan.
Bugs: MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4633
Repository: mesos
Description
-------
Makes the following changes:
* All objects passed to `StartSlave` are transformed into `shared_ptr`.
* References to the above objects are updated to reflect the different type.
* Removes `Shutdown()` in at the end of all tests, except for master tests that have a stack-allocated dependency.
* Removes manual `delete`s inside tests.
* Generally renames test variables to be more consistent (i.e. `exec` -> `executor` and `dockerContainerizer` -> `containerizer`).
* Removes extraneous spaces in `Try<PID<Slave> >` in touched lines.
Diffs
-----
src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1
src/tests/master_quota_tests.cpp 2255fc230f0821eeaba332997f30ff9922e4f317
src/tests/resource_offers_tests.cpp 0bad45dd1dabecc88fef1ab46e8ea26718070b33
Diff: https://reviews.apache.org/r/43441/diff/
Testing
-------
Tests are run at the very, very end of this review chain.
Thanks,
Joseph Wu