You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/03 12:11:59 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request, #6996: sched/wqueue: fix visual studio Compiler Error C2059
anchao opened a new pull request, #6996:
URL: https://github.com/apache/incubator-nuttx/pull/6996
## Summary
sched/wqueue: fix visual studio Compiler Error C2059
Designated initializers are a C99 (or newer) feature, and Visual Studio doesn't (part) support C99 (or newer).
`D:\code\incubator-nuttx\sched\wqueue\kwork_thread.c(94,50): error C2059: syntax error : ','`
Reference:
https://docs.microsoft.com/en-us/cpp/overview/visual-cpp-language-conformance?view=msvc-160#c-standard-library-features-1
https://docs.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/compiler-error-c2059?view=msvc-170
Signed-off-by: chao an <an...@xiaomi.com>
## Impact
N/A
## Testing
visio studio + cmake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6996: sched/wqueue: fix visual studio Compiler Error C2059
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6996:
URL: https://github.com/apache/incubator-nuttx/pull/6996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6996: sched/wqueue: fix visual studio Compiler Error C2059
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6996:
URL: https://github.com/apache/incubator-nuttx/pull/6996#discussion_r962154008
##########
sched/wqueue/kwork_thread.c:
##########
@@ -79,7 +79,7 @@
struct hp_wqueue_s g_hpwork =
{
- {},
+ {0},
Review Comment:
```suggestion
{NULL, NULL},
```
##########
sched/wqueue/kwork_thread.c:
##########
@@ -90,7 +90,7 @@ struct hp_wqueue_s g_hpwork =
struct lp_wqueue_s g_lpwork =
{
- {},
+ {0},
Review Comment:
```suggestion
{NULL, NULL},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6996: sched/wqueue: fix visual studio Compiler Error C2059
Posted by GitBox <gi...@apache.org>.
anchao commented on code in PR #6996:
URL: https://github.com/apache/incubator-nuttx/pull/6996#discussion_r962155345
##########
sched/wqueue/kwork_thread.c:
##########
@@ -90,7 +90,7 @@ struct hp_wqueue_s g_hpwork =
struct lp_wqueue_s g_lpwork =
{
- {},
+ {0},
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org