You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by cjpearson <gi...@git.apache.org> on 2015/02/25 17:38:40 UTC
[GitHub] cordova-plugin-inappbrowser pull request: CB-8534: Add support for...
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/82
CB-8534: Add support for auth dialogs in inappbrowser plugin
When an authentication challenge is received, the inappbrowser will now check to see if a plugin can respond to the challenge before going to the default behavior. This is the same behavior that was added to cordova-android in CB-8201. It allows plugins like [Auth Dialog](https://github.com/MSOpenTech/cordova-plugin-auth-dialog) to work with the inappbrowser.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cjpearson/cordova-plugin-inappbrowser master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/82.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #82
----
commit e607ac63eed97b420c07a328d7c6bfce6d9d49ec
Author: Connor Pearson <cj...@gmail.com>
Date: 2015-02-24T16:51:38Z
CB-8534: Allow plugins to respond to onReceivedHttpAuthRequest
commit e3b1a06fe37dfdde55df7ce810c429390e25cf6f
Author: Connor Pearson <cj...@gmail.com>
Date: 2015-02-24T18:48:14Z
If getPluginManager does not work access the field directly
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-8534: Add support for...
Posted by adrianchia <gi...@git.apache.org>.
Github user adrianchia commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/82#issuecomment-115076069
Hi,
Is this pull request going to be in the cordova inappbrowser plugin soon?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-8534: Add support for...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/82#issuecomment-158460236
Verified and merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-8534: Add support for...
Posted by helzgate <gi...@git.apache.org>.
Github user helzgate commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/82#issuecomment-124594070
You could use cordova-plugin-auth-dialog with the webview instead on inAppBrowser. I just had to remove about 4 lines in a source xml file that was causing issues while building. Other than that it works great and i'm loving it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-8534: Add support for...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/82
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #82: CB-8534: Add support for auth dialogs...
Posted by hmusunuru <gi...@git.apache.org>.
Github user hmusunuru commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/82
@sgrebnov will this work for both ios and android
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org