You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2018/07/17 14:48:46 UTC
[Impala-ASF-CR](2.x) IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.
Hello Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10960
to review the following change.
Change subject: IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.
......................................................................
IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.
Impala master branch can already write the Parquet
page index. However, we still don't have a well-defined
ordering for floating-point numbers in Parquet, see
PARQUET-1222
Currently impala writes the page index with
fmax()/fmin() semantics, but it might contradicts the
future semantics that will be defined once PARQUET-1222
is resolved.
From this patch Impala won't write the column index
for floating-point columns until PARQUET-1222 is
resolved and implemented.
I updated the python test accordingly.
Change-Id: I50aa2e6607de6a8943eb068b8162b0506763078b
Reviewed-on: http://gerrit.cloudera.org:8080/10951
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
(cherry picked from commit 041197444d2a73bc3e3da4c6dbfdf1d63c236fbf)
---
M be/src/exec/hdfs-parquet-table-writer.cc
M tests/query_test/test_parquet_page_index.py
2 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/10960/1
--
To view, visit http://gerrit.cloudera.org:8080/10960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50aa2e6607de6a8943eb068b8162b0506763078b
Gerrit-Change-Number: 10960
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10960 )
Change subject: IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2825/
--
To view, visit http://gerrit.cloudera.org:8080/10960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I50aa2e6607de6a8943eb068b8162b0506763078b
Gerrit-Change-Number: 10960
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Jul 2018 18:36:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10960 )
Change subject: IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.
......................................................................
IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.
Impala master branch can already write the Parquet
page index. However, we still don't have a well-defined
ordering for floating-point numbers in Parquet, see
PARQUET-1222
Currently impala writes the page index with
fmax()/fmin() semantics, but it might contradicts the
future semantics that will be defined once PARQUET-1222
is resolved.
From this patch Impala won't write the column index
for floating-point columns until PARQUET-1222 is
resolved and implemented.
I updated the python test accordingly.
Change-Id: I50aa2e6607de6a8943eb068b8162b0506763078b
Reviewed-on: http://gerrit.cloudera.org:8080/10951
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
(cherry picked from commit 041197444d2a73bc3e3da4c6dbfdf1d63c236fbf)
Reviewed-on: http://gerrit.cloudera.org:8080/10960
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
Tested-by: Zoltan Borok-Nagy <bo...@cloudera.com>
---
M be/src/exec/hdfs-parquet-table-writer.cc
M tests/query_test/test_parquet_page_index.py
2 files changed, 11 insertions(+), 0 deletions(-)
Approvals:
Zoltan Borok-Nagy: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/10960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I50aa2e6607de6a8943eb068b8162b0506763078b
Gerrit-Change-Number: 10960
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has removed a vote on this change.
Change subject: IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.
......................................................................
Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/10960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I50aa2e6607de6a8943eb068b8162b0506763078b
Gerrit-Change-Number: 10960
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10960 )
Change subject: IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2825/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/10960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I50aa2e6607de6a8943eb068b8162b0506763078b
Gerrit-Change-Number: 10960
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Jul 2018 14:50:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10960 )
Change subject: IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I50aa2e6607de6a8943eb068b8162b0506763078b
Gerrit-Change-Number: 10960
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Jul 2018 14:49:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10960 )
Change subject: IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.
......................................................................
Patch Set 1: Verified+1
It was a trivial cherry-pick, GVO failed for other reasons, verified +1
--
To view, visit http://gerrit.cloudera.org:8080/10960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I50aa2e6607de6a8943eb068b8162b0506763078b
Gerrit-Change-Number: 10960
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Jul 2018 10:31:35 +0000
Gerrit-HasComments: No