You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2010/01/19 13:22:23 UTC
[Bug 6292] New: tweak announcement mail to not use "curl"/"sa-update
--import"
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6292
Summary: tweak announcement mail to not use "curl"/"sa-update
--import"
Product: Spamassassin
Version: 3.3.0
Platform: Other
OS/Version: All
Status: NEW
Severity: minor
Priority: P5
Component: Building & Packaging
AssignedTo: dev@spamassassin.apache.org
ReportedBy: jm@jmason.org
Minor tweak to the announcement mail before 3.3.0 goes out. IMO this
does not need revoting on the tarballs.
On Tue, Jan 19, 2010 at 02:10, Sidney Markowitz <si...@sidney.com> wrote:
> Justin Mason wrote, On 19/01/10 12:55 PM:
>> proposed release announcement mail is there, too. We need 3 +1 votes
>> and no -1's over the next 72 hours to "bless" this as an official
>> release.
>
> I have an issue with the proposed release announcement. Not enough for a
> hard -1 vote, but we can change it without canceling the release, correct?
>
> It says to install rules by either running sa-update as root, or going
> through a series of steps for installing from files that has you
> download GPG.KEY using curl and then importing the key and then running
> sa-update on the downloaded tarball.
Actually, this *is* wrong, but not in the way you thought ;)
As noted, the rule-update signing key has not changed, since it was
already 4096-bit. This means that the "curl" step is not necessary at
all, since the distributed sa-update already knows about that key
and trusts it out-of-the-box. I propose we replace the section of the
mail text with this:
==============================================
INSTALLING RULES
Rules are normally installed by running a sa-update command.
The version of sa-update program should match the version of SpamAssassin
modules, so invoking sa-update should be performed only after installing
or upgrading SpamAssassin code, not before.
Installing rules from network is done with a single command,
normally run as root:
sa-update
Installing rules from files:
obtain all the following files:
Mail-SpamAssassin-rules-xxx.tgz
Mail-SpamAssassin-rules-xxx.tgz.asc
Mail-SpamAssassin-rules-xxx.tgz.md5
Mail-SpamAssassin-rules-xxx.tgz.sha1
(where xxx may look something like '3.3.0.r893295')
install rules from a compressed tar archive:
sa-update --install Mail-SpamAssassin-rules-xxx.tgz
(sa-update will need corresponding .asc and .sha1 files with the
same base name in a current directory)
==============================================
I've tested this and it works fine.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6292] [review] tweak announcement mail to not use
"curl"/"sa-update --import"
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6292
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|1 more vote wouldn't hurt |
|:) |
--- Comment #4 from Mark Martinec <Ma...@ijs.si> 2010-01-19 15:54:12 UTC ---
+1
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6292] [review] tweak announcement mail to not use
"curl"/"sa-update --import"
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6292
Justin Mason <jm...@jmason.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #5 from Justin Mason <jm...@jmason.org> 2010-01-20 04:31:52 UTC ---
applied, thanks.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6292] [review] tweak announcement mail to not use
"curl"/"sa-update --import"
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6292
Sidney Markowitz <si...@sidney.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sidney@sidney.com
Status Whiteboard| |1 more vote wouldn't hurt
| |:)
--- Comment #3 from Sidney Markowitz <si...@sidney.com> 2010-01-19 10:42:09 UTC ---
+1
Does this need votes?
BTW, http://spamassassin.apache.org/updates/GPG.KEY will still have to be
updated with the cross-signed key even if it doesn't need to be downloaded with
a new sa-update install.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6292] tweak announcement mail to not use "curl"/"sa-update
--import"
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6292
Justin Mason <jm...@jmason.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 |P1
CC| |jm@jmason.org
Target Milestone|Undefined |3.3.0
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6292] [review] tweak announcement mail to not use
"curl"/"sa-update --import"
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6292
Justin Mason <jm...@jmason.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|tweak announcement mail to |[review] tweak announcement
|not use "curl"/"sa-update |mail to not use
|--import" |"curl"/"sa-update --import"
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6292] tweak announcement mail to not use "curl"/"sa-update
--import"
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6292
--- Comment #2 from Justin Mason <jm...@jmason.org> 2010-01-19 04:24:52 UTC ---
Created an attachment (id=4649)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4649)
trivial fix
here's the change in diff form for review.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6292] tweak announcement mail to not use "curl"/"sa-update
--import"
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6292
--- Comment #1 from Justin Mason <jm...@jmason.org> 2010-01-19 04:23:50 UTC ---
btw the curl step as currently appears in the release announcement text is
harmless. it's just superfluous.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.