You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Matt Jones (JIRA)" <ji...@apache.org> on 2012/09/19 11:22:07 UTC
[jira] [Created] (SHINDIG-1873) Incorrectly parsed moduleId in
TokenRequestData
Matt Jones created SHINDIG-1873:
-----------------------------------
Summary: Incorrectly parsed moduleId in TokenRequestData
Key: SHINDIG-1873
URL: https://issues.apache.org/jira/browse/SHINDIG-1873
Project: Shindig
Issue Type: Bug
Components: Java
Affects Versions: 2.5.0-beta4
Reporter: Matt Jones
When a gadgets:token RPC request is made the gadget's module ID is encoded with the gadget's URL in the form:
[gadget URL]#[module ID] (features/src/main/javascript/features/container.util/util.js line 191)
However, when the module ID is parsed out by the container, it seems to expect it in the form:
[gadget URL]#moduleId=[moduleId] (GadgetsHandler.TokenRequestData, line 575)
This means moduleId is never parsed and the RPC request always returns a moduleId of zero.
The comment above the container code seems to imply that the JS encoding is correct and therefore the container's code is at fault.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHINDIG-1873) Incorrectly parsed moduleId in
TokenRequestData
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Dumont resolved SHINDIG-1873.
---------------------------------
Resolution: Fixed
Fix Version/s: 2.5.0-beta5
Committed r1389503
> Incorrectly parsed moduleId in TokenRequestData
> -----------------------------------------------
>
> Key: SHINDIG-1873
> URL: https://issues.apache.org/jira/browse/SHINDIG-1873
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0-beta4
> Reporter: Matt Jones
> Fix For: 2.5.0-beta5
>
> Attachments: fix-SHINDIG-1873-2-bug.patch, fix-SHINDIG-1873-bug.patch
>
>
> When a gadgets:token RPC request is made the gadget's module ID is encoded with the gadget's URL in the form:
> [gadget URL]#[module ID] (features/src/main/javascript/features/container.util/util.js line 191)
> However, when the module ID is parsed out by the container, it seems to expect it in the form:
> [gadget URL]#moduleId=[moduleId] (GadgetsHandler.TokenRequestData, line 575)
> This means moduleId is never parsed and the RPC request always returns a moduleId of zero.
> The comment above the container code seems to imply that the JS encoding is correct and therefore the container's code is at fault.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1873) Incorrectly parsed moduleId in
TokenRequestData
Posted by "Matt Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Jones updated SHINDIG-1873:
--------------------------------
Attachment: fix-SHINDIG-1873-2-bug.patch
New patch per review.
> Incorrectly parsed moduleId in TokenRequestData
> -----------------------------------------------
>
> Key: SHINDIG-1873
> URL: https://issues.apache.org/jira/browse/SHINDIG-1873
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0-beta4
> Reporter: Matt Jones
> Attachments: fix-SHINDIG-1873-2-bug.patch, fix-SHINDIG-1873-bug.patch
>
>
> When a gadgets:token RPC request is made the gadget's module ID is encoded with the gadget's URL in the form:
> [gadget URL]#[module ID] (features/src/main/javascript/features/container.util/util.js line 191)
> However, when the module ID is parsed out by the container, it seems to expect it in the form:
> [gadget URL]#moduleId=[moduleId] (GadgetsHandler.TokenRequestData, line 575)
> This means moduleId is never parsed and the RPC request always returns a moduleId of zero.
> The comment above the container code seems to imply that the JS encoding is correct and therefore the container's code is at fault.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1873) Incorrectly parsed moduleId in
TokenRequestData
Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458675#comment-13458675 ]
Ryan Baxter commented on SHINDIG-1873:
--------------------------------------
Matt thanks for the patch! Can you create a review at reviews.apache.org and add the shindig community as a reviewer? I would like you to get some kudos for submitting the patch. Thanks.
> Incorrectly parsed moduleId in TokenRequestData
> -----------------------------------------------
>
> Key: SHINDIG-1873
> URL: https://issues.apache.org/jira/browse/SHINDIG-1873
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0-beta4
> Reporter: Matt Jones
> Attachments: fix-SHINDIG-1873-bug.patch
>
>
> When a gadgets:token RPC request is made the gadget's module ID is encoded with the gadget's URL in the form:
> [gadget URL]#[module ID] (features/src/main/javascript/features/container.util/util.js line 191)
> However, when the module ID is parsed out by the container, it seems to expect it in the form:
> [gadget URL]#moduleId=[moduleId] (GadgetsHandler.TokenRequestData, line 575)
> This means moduleId is never parsed and the RPC request always returns a moduleId of zero.
> The comment above the container code seems to imply that the JS encoding is correct and therefore the container's code is at fault.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1873) Incorrectly parsed moduleId in
TokenRequestData
Posted by "Matt Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Jones updated SHINDIG-1873:
--------------------------------
Attachment: fix-SHINDIG-1873-bug.patch
Patch attached
> Incorrectly parsed moduleId in TokenRequestData
> -----------------------------------------------
>
> Key: SHINDIG-1873
> URL: https://issues.apache.org/jira/browse/SHINDIG-1873
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0-beta4
> Reporter: Matt Jones
> Attachments: fix-SHINDIG-1873-bug.patch
>
>
> When a gadgets:token RPC request is made the gadget's module ID is encoded with the gadget's URL in the form:
> [gadget URL]#[module ID] (features/src/main/javascript/features/container.util/util.js line 191)
> However, when the module ID is parsed out by the container, it seems to expect it in the form:
> [gadget URL]#moduleId=[moduleId] (GadgetsHandler.TokenRequestData, line 575)
> This means moduleId is never parsed and the RPC request always returns a moduleId of zero.
> The comment above the container code seems to imply that the JS encoding is correct and therefore the container's code is at fault.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira