You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/10 20:16:56 UTC
[GitHub] [airflow] pierrejeambrun opened a new pull request, #25654: Remove useless statement in task_group_to_grid
pierrejeambrun opened a new pull request, #25654:
URL: https://github.com/apache/airflow/pull/25654
This PR just removes a statement that had no effect.
We keep sending possibly 'None' state in the grid data except for the 'mapped_states' count. (None keys in json are an issue)
I have another version of this PR [here](https://github.com/apache/airflow/compare/main...pierrejeambrun:airflow:fix-task-group-to-grid-no-status), where instead, None status are changed to 'no_status' in the entire returned payload. I don't think this is a good idea because either way the front will still have to handle None state. (Other endpoints returning `TaskInstance` will not do this transformation).
I plan to work on `grid_data` endpoint api_connexion.TaskInstance. (run_id vs dag_run_id and other differences), to be able to unify those types in the front. (They are not playing nice with each other right now)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #25654: Remove useless statement in task_group_to_grid
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on PR #25654:
URL: https://github.com/apache/airflow/pull/25654#issuecomment-1211279267
> So the grid_data endpoint is "private"/"internal" which means the format of the data it returns should be tailored to exactly what the UI needs, and not generic like the OpenAPI REST API. So only change the format if it makes the UI cleaner (don't just do it for the sake of it in other words)
Yeah, that's the plan. There's some inconsistencies between the task instances in the internal `grid_data` and the REST `get_mapped_instances`. That's what Pierre wants to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #25654: Remove useless statement in task_group_to_grid
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #25654:
URL: https://github.com/apache/airflow/pull/25654#issuecomment-1211271211
> I plan to work on grid_data endpoint follow the api_connexion.TaskInstance schema. (run_id vs dag_run_id and other differences), to be able to unify those types in the front. (They are not playing nice with each other right now)
So the grid_data endpoint is "private"/"internal" which means the format of the data it returns should be tailored to exactly what the UI needs, and not generic like the OpenAPI REST API. So only change the format if it makes the UI cleaner (don't just do it for the sake of it in other words)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #25654: Remove useless statement in task_group_to_grid
Posted by GitBox <gi...@apache.org>.
bbovenzi merged PR #25654:
URL: https://github.com/apache/airflow/pull/25654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on pull request #25654: Remove useless statement in task_group_to_grid
Posted by GitBox <gi...@apache.org>.
pierrejeambrun commented on PR #25654:
URL: https://github.com/apache/airflow/pull/25654#issuecomment-1211307882
Understood @ashb, thanks for the details :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org