You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "Gary-Hobson (via GitHub)" <gi...@apache.org> on 2023/01/31 16:07:42 UTC
[GitHub] [nuttx] Gary-Hobson opened a new pull request, #8384: Makefile: fix redundant delimiters when using make V=1
Gary-Hobson opened a new pull request, #8384:
URL: https://github.com/apache/nuttx/pull/8384
## Summary
When using make V=1, the obj file will print two separators in the libc and mm directories
Use the [ realpath function](https://www.gnu.org/software/make/manual/html_node/File-Name-Functions.html#:~:text=File%20Names.-,%24(realpath%20names%E2%80%A6),-For%20each%20file) to return a canonical relative path to remove redundant separators
```
arm-none-eabi-ar rcs libc.a bin//lib_assert.o bin//lib_builtin_getname.o
```
## Impact
@zouboan Please help to verify whether it can run normally in the windows environment
## Testing
ubuntu sim/nsh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] zouboan commented on pull request #8384: Makefile: fix redundant delimiters when using make V=1
Posted by "zouboan (via GitHub)" <gi...@apache.org>.
zouboan commented on PR #8384:
URL: https://github.com/apache/nuttx/pull/8384#issuecomment-1412085094
Let me test Windows native build on your new solution #8391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis merged pull request #8384: Makefile: fix redundant delimiters when using make V=1
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #8384:
URL: https://github.com/apache/nuttx/pull/8384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #8384: Makefile: fix redundant delimiters when using make V=1
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #8384:
URL: https://github.com/apache/nuttx/pull/8384#issuecomment-1410854097
Thank you @Gary-Hobson ! I missed that PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] Gary-Hobson commented on pull request #8384: Makefile: fix redundant delimiters when using make V=1
Posted by "Gary-Hobson (via GitHub)" <gi...@apache.org>.
Gary-Hobson commented on PR #8384:
URL: https://github.com/apache/nuttx/pull/8384#issuecomment-1410824575
> @Gary-Hobson seems there are other places that need to be fixed too, after applying this patch I can see it:
>
> ```
> arm-none-eabi-gcc -c -Wstrict-prototypes -Os -fno-strict-aliasing -fomit-frame-pointer -mthumb -Wa,-mthumb -Wa,-mimplicit-it=always -fno-common -Wall -Wshadow -Wundef -ffunction-sections -fdata-sections -mlittle-endian -march=armv7e-m -mtune=cortex-m4 -mfloat-abi=soft -isystem /home/alan/nuttxspace/nuttx/include -D__NuttX__ -DNDEBUG -pipe -I /home/alan/nuttxspace/nuttx/libs/libc /home/alan/nuttxspace/nuttx/libs/libc/assert/lib_assert.c -o bin//lib_assert.o
> ```
This should not happen, are you using the latest master branch
This PR (https://github.com/apache/nuttx/pull/8347) will use the full path when compiling, and no relative path will appear in the compile command
```
arm-none-eabi-gcc -c -Wstrict-prototypes -Os -fno-strict-aliasing -fomit-frame-pointer -mthumb -Wa,-mthumb -Wa,-mimplicit-it=always -fno-common -Wall -Wshadow -Wundef -ffunction-sections -fdata-sections -g -mlittle-endian -march=armv7e-m -mtune=cortex-m7 -mfpu=fpv5-d16 -mfloat-abi=hard -isystem /home/baerg/vela/NXOS/nuttx/include -D__NuttX__ -pipe -I /home/baerg/vela/NXOS/nuttx/libs/libc /home/baerg/vela/NXOS/nuttx/libs/libc/assert/lib_assert.c -o /home/baerg/vela/NXOS/nuttx/libs/libc/bin/lib_assert.o
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8384: Makefile: fix redundant delimiters when using make V=1
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8384:
URL: https://github.com/apache/nuttx/pull/8384#discussion_r1092414447
##########
mm/Makefile:
##########
@@ -52,18 +52,18 @@ all: $(BIN)
.PHONY: context depend clean distclean
$(AOBJS): $(BINDIR)$(DELIM)$(DELIM)%$(OBJEXT): %.S
- $(call ASSEMBLE, $<, $@)
+ $(call ASSEMBLE, $(realpath $<), $@)
Review Comment:
but why not move the realpath to ASSEMBLE/COMPILE macro/function instead. There are many place call ASSEBLE/COMPILE/COMPILEXX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #8384: Makefile: fix redundant delimiters when using make V=1
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #8384:
URL: https://github.com/apache/nuttx/pull/8384#issuecomment-1410781165
@Gary-Hobson seems there are other places that need to be fixed too, after applying this patch I can see it:
```
arm-none-eabi-gcc -c -Wstrict-prototypes -Os -fno-strict-aliasing -fomit-frame-pointer -mthumb -Wa,-mthumb -Wa,-mimplicit-it=always -fno-common -Wall -Wshadow -Wundef -ffunction-sections -fdata-sections -mlittle-endian -march=armv7e-m -mtune=cortex-m4 -mfloat-abi=soft -isystem /home/alan/nuttxspace/nuttx/include -D__NuttX__ -DNDEBUG -pipe -I /home/alan/nuttxspace/nuttx/libs/libc /home/alan/nuttxspace/nuttx/libs/libc/assert/lib_assert.c -o bin//lib_assert.o
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org