[GitHub] [lucene-solr] noblepaul edited a comment on pull request #1730: SOLR-14680: Provide simple interfaces to our concrete SolrCloud classes

[GitBox <gi...@apache.org>]

noblepaul edited a comment on pull request #1730:
URL: https://github.com/apache/lucene-solr/pull/1730#issuecomment-671229892


   > Separating out the new lazy implementations into another PR and keeping this one for adding interfaces to internal classes would have made reviewing easier.
   
   Yeah, that was the other PR #1694 , I have revived it
   
   >Are there places in the code where currently the concrete classes are used and that could be changed to use the interfaces instead? In other words, how/where would these interfaces be used?
   
   The current concrete classes do not use/implement these interfaces. These interfaces will only be a part of implementations. for instance, the `LazySolrCluster` is one of the impl. In the future we should add a couple more
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org