You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by "Jason Giedymin (JIRA)" <ji...@apache.org> on 2010/01/28 21:47:34 UTC

[jira] Created: (TS-118) SSL Cert location in trunk slightly misleading or confusing

SSL Cert location in trunk slightly misleading or confusing
-----------------------------------------------------------

                 Key: TS-118
                 URL: https://issues.apache.org/jira/browse/TS-118
             Project: Traffic Server
          Issue Type: Bug
          Components: Config
         Environment: Ubuntu 9.10
            Reporter: Jason Giedymin
            Priority: Minor


In Trunk, [records.config] reads:

CONFIG proxy.config.ssl.server.cert.path STRING @prefix@/etc/@PACKAGE@

However, @prefix is implied.

Recommend:

CONFIG proxy.config.ssl.server.cert.path STRING /etc/@PACKAGE@

Patch provided with additional config comments provided.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (TS-118) SSL Cert location in trunk slightly misleading or confusing

Posted by "George Paul (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

George Paul reassigned TS-118:
------------------------------

    Assignee: George Paul

> SSL Cert location in trunk slightly misleading or confusing
> -----------------------------------------------------------
>
>                 Key: TS-118
>                 URL: https://issues.apache.org/jira/browse/TS-118
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Config
>         Environment: Ubuntu 9.10
>            Reporter: Jason Giedymin
>            Assignee: George Paul
>            Priority: Minor
>             Fix For: 2.0.0a
>
>         Attachments: TS-118.patch
>
>
> In Trunk, [records.config] reads:
> CONFIG proxy.config.ssl.server.cert.path STRING @prefix@/etc/@PACKAGE@
> However, @prefix is implied.
> Recommend:
> CONFIG proxy.config.ssl.server.cert.path STRING /etc/@PACKAGE@
> Patch provided with additional config comments provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-118) SSL Cert location in trunk slightly misleading or confusing

Posted by "Jason Giedymin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806112#action_12806112 ] 

Jason Giedymin commented on TS-118:
-----------------------------------

It seems a few config valus have fully qualified values, such as:

proxy.config.ssl.client.cert.path

> SSL Cert location in trunk slightly misleading or confusing
> -----------------------------------------------------------
>
>                 Key: TS-118
>                 URL: https://issues.apache.org/jira/browse/TS-118
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Config
>         Environment: Ubuntu 9.10
>            Reporter: Jason Giedymin
>            Priority: Minor
>
> In Trunk, [records.config] reads:
> CONFIG proxy.config.ssl.server.cert.path STRING @prefix@/etc/@PACKAGE@
> However, @prefix is implied.
> Recommend:
> CONFIG proxy.config.ssl.server.cert.path STRING /etc/@PACKAGE@
> Patch provided with additional config comments provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TS-118) SSL Cert location in trunk slightly misleading or confusing

Posted by "George Paul (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

George Paul resolved TS-118.
----------------------------

    Resolution: Fixed

Committed 'TS118_patch3.diff' to trunk and  moved path handling issue to TS-140.

-George

> SSL Cert location in trunk slightly misleading or confusing
> -----------------------------------------------------------
>
>                 Key: TS-118
>                 URL: https://issues.apache.org/jira/browse/TS-118
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Config
>         Environment: Ubuntu 9.10
>            Reporter: Jason Giedymin
>            Assignee: George Paul
>            Priority: Minor
>             Fix For: 2.0.0a
>
>         Attachments: TS-118.patch, TS118_patch2.diff
>
>
> In Trunk, [records.config] reads:
> CONFIG proxy.config.ssl.server.cert.path STRING @prefix@/etc/@PACKAGE@
> However, @prefix is implied.
> Recommend:
> CONFIG proxy.config.ssl.server.cert.path STRING /etc/@PACKAGE@
> Patch provided with additional config comments provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-118) SSL Cert location in trunk slightly misleading or confusing

Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829417#action_12829417 ] 

Leif Hedstrom commented on TS-118:
----------------------------------

I think this looks good, I'm assuming you have tested all the cases? So, r=leif.

One comment though (feel free to file a separate bug on this  if you prefer to close this one):

To me, it's very confusing that setting a "path" config to say /etc/trafficserver is still relative to ${prefix) (i.e. it becomes /usr/local/etc/trafficserver). In any normal universe, an absolute path like that would be used as such. So, my proposal is that we redo all handling of such paths, so that

    etc/trafficserver


gets prepended with ${prefix} (e.g. /usr/local/, with the final path being /usr/local/etc/trafficserver), while

    /etc/trafficserver

is not (i.e. the path stays /etc/trafficserver).



> SSL Cert location in trunk slightly misleading or confusing
> -----------------------------------------------------------
>
>                 Key: TS-118
>                 URL: https://issues.apache.org/jira/browse/TS-118
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Config
>         Environment: Ubuntu 9.10
>            Reporter: Jason Giedymin
>            Assignee: George Paul
>            Priority: Minor
>             Fix For: 2.0.0a
>
>         Attachments: TS-118.patch, TS118_patch2.diff
>
>
> In Trunk, [records.config] reads:
> CONFIG proxy.config.ssl.server.cert.path STRING @prefix@/etc/@PACKAGE@
> However, @prefix is implied.
> Recommend:
> CONFIG proxy.config.ssl.server.cert.path STRING /etc/@PACKAGE@
> Patch provided with additional config comments provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TS-118) SSL Cert location in trunk slightly misleading or confusing

Posted by "George Paul (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

George Paul updated TS-118:
---------------------------

    Attachment: TS118_patch2.diff

svnversion: 905494
This patch 'TS118_patch2.diff' addresses the relative path issue for base SSL cert paths. This patch also sets the defaults back to relative paths. Also converted 'conf/yts' -> 'etc/trafficserver' throughout the code base.

Please review and let me know if there are any issues.
Tested on Ubuntu904 and Fedora11.

-George

> SSL Cert location in trunk slightly misleading or confusing
> -----------------------------------------------------------
>
>                 Key: TS-118
>                 URL: https://issues.apache.org/jira/browse/TS-118
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Config
>         Environment: Ubuntu 9.10
>            Reporter: Jason Giedymin
>            Assignee: George Paul
>            Priority: Minor
>             Fix For: 2.0.0a
>
>         Attachments: TS-118.patch, TS118_patch2.diff
>
>
> In Trunk, [records.config] reads:
> CONFIG proxy.config.ssl.server.cert.path STRING @prefix@/etc/@PACKAGE@
> However, @prefix is implied.
> Recommend:
> CONFIG proxy.config.ssl.server.cert.path STRING /etc/@PACKAGE@
> Patch provided with additional config comments provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-118) SSL Cert location in trunk slightly misleading or confusing

Posted by "Jason Giedymin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828700#action_12828700 ] 

Jason Giedymin commented on TS-118:
-----------------------------------

Will try to get this tested today.




> SSL Cert location in trunk slightly misleading or confusing
> -----------------------------------------------------------
>
>                 Key: TS-118
>                 URL: https://issues.apache.org/jira/browse/TS-118
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Config
>         Environment: Ubuntu 9.10
>            Reporter: Jason Giedymin
>            Assignee: George Paul
>            Priority: Minor
>             Fix For: 2.0.0a
>
>         Attachments: TS-118.patch, TS118_patch2.diff
>
>
> In Trunk, [records.config] reads:
> CONFIG proxy.config.ssl.server.cert.path STRING @prefix@/etc/@PACKAGE@
> However, @prefix is implied.
> Recommend:
> CONFIG proxy.config.ssl.server.cert.path STRING /etc/@PACKAGE@
> Patch provided with additional config comments provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TS-118) SSL Cert location in trunk slightly misleading or confusing

Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leif Hedstrom updated TS-118:
-----------------------------

    Fix Version/s: 2.0.0a

> SSL Cert location in trunk slightly misleading or confusing
> -----------------------------------------------------------
>
>                 Key: TS-118
>                 URL: https://issues.apache.org/jira/browse/TS-118
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Config
>         Environment: Ubuntu 9.10
>            Reporter: Jason Giedymin
>            Priority: Minor
>             Fix For: 2.0.0a
>
>         Attachments: TS-118.patch
>
>
> In Trunk, [records.config] reads:
> CONFIG proxy.config.ssl.server.cert.path STRING @prefix@/etc/@PACKAGE@
> However, @prefix is implied.
> Recommend:
> CONFIG proxy.config.ssl.server.cert.path STRING /etc/@PACKAGE@
> Patch provided with additional config comments provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TS-118) SSL Cert location in trunk slightly misleading or confusing

Posted by "Jason Giedymin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Giedymin updated TS-118:
------------------------------

    Attachment: TS-118.patch

> SSL Cert location in trunk slightly misleading or confusing
> -----------------------------------------------------------
>
>                 Key: TS-118
>                 URL: https://issues.apache.org/jira/browse/TS-118
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Config
>         Environment: Ubuntu 9.10
>            Reporter: Jason Giedymin
>            Priority: Minor
>         Attachments: TS-118.patch
>
>
> In Trunk, [records.config] reads:
> CONFIG proxy.config.ssl.server.cert.path STRING @prefix@/etc/@PACKAGE@
> However, @prefix is implied.
> Recommend:
> CONFIG proxy.config.ssl.server.cert.path STRING /etc/@PACKAGE@
> Patch provided with additional config comments provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-118) SSL Cert location in trunk slightly misleading or confusing

Posted by "Jason Giedymin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806125#action_12806125 ] 

Jason Giedymin commented on TS-118:
-----------------------------------

Patch attached.

> SSL Cert location in trunk slightly misleading or confusing
> -----------------------------------------------------------
>
>                 Key: TS-118
>                 URL: https://issues.apache.org/jira/browse/TS-118
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Config
>         Environment: Ubuntu 9.10
>            Reporter: Jason Giedymin
>            Priority: Minor
>         Attachments: TS-118.patch
>
>
> In Trunk, [records.config] reads:
> CONFIG proxy.config.ssl.server.cert.path STRING @prefix@/etc/@PACKAGE@
> However, @prefix is implied.
> Recommend:
> CONFIG proxy.config.ssl.server.cert.path STRING /etc/@PACKAGE@
> Patch provided with additional config comments provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.