You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2009/03/31 22:00:34 UTC
DO NOT REPLY [Bug 46947] New: Code cleanup patch that removes some
obsolete null checks
https://issues.apache.org/bugzilla/show_bug.cgi?id=46947
Summary: Code cleanup patch that removes some obsolete null
checks
Product: Tomcat 6
Version: unspecified
Platform: PC
OS/Version: Linux
Status: NEW
Severity: enhancement
Priority: P5
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: lkuehne@apache.org
Created an attachment (id=23432)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=23432)
Patch against trunk
As discussed at ApacheCon with Mark and Peter, here is a patch against trunk
that removes obsolete null checks where the variable has already been
dereferenced earlier.
The patch doesn't fix all issues that Findbugs reports in the "RCN" category. I
was not able to confirm the remaining ones and I suspect some false alarms.
Note to reviewer: The diffs for Generator.java are quite hard to follow in the
patch file, maybe it's easier for you to just remove the "if (attrInfos !=
null)" check yourself in the original code.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 46947] Code cleanup patch that removes some
obsolete null checks
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46947
Tim Funk <fu...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #1 from Tim Funk <fu...@apache.org> 2009-11-03 16:54:46 UTC ---
applied to trunk (tomcat7) - don't intend to cleanup tomcat6 (unless someone
has the itch to reopen)
commit revision 832636
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org