You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2021/10/20 17:58:39 UTC

[GitHub] [incubator-heron] joshfischer1108 commented on pull request #3710: [HERON-3707] ConfigMap Pod Template Support

joshfischer1108 commented on pull request #3710:
URL: https://github.com/apache/incubator-heron/pull/3710#issuecomment-947905924


   > I have added a check for multiple `executor` container specifications in the provided Pod Template. I am conflicted about whether we should be checking for this. It should not be the responsibility of the framework to verify a valid Pod Template. The complete battery of tests is passing locally.
   > 
   > @nicknezis I think it is safe to say that the core of the functionality for the is feature is now complete, and as such, I am leaving this PR until review. I am also pinging @joshfischer1108 in case we need more reviewers.
   
   I'll be able to look over this PR and the accompanying docs this weekend. I've recently restarted the build as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org