[GitHub] [pinot] jackjlli commented on a diff in pull request #9391: broker filter

[GitBox <gi...@apache.org>]

jackjlli commented on code in PR #9391:
URL: https://github.com/apache/pinot/pull/9391#discussion_r971342975


##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/HttpRequesterIdentity.java:
##########
@@ -30,6 +31,17 @@ public class HttpRequesterIdentity extends RequesterIdentity {
   private Multimap<String, String> _httpHeaders;
   private String _endpointUrl;
 
+  public static HttpRequesterIdentity fromRequest(org.glassfish.grizzly.http.server.Request request) {

Review Comment:
   nit: import `org.glassfish.grizzly.http.server.Request` instead of specifying the full path here?



##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/AccessControl.java:
##########
@@ -47,4 +47,13 @@ default boolean hasAccess(RequesterIdentity requesterIdentity) {
    * @return {@code true} if authorized, {@code false} otherwise
    */
   boolean hasAccess(RequesterIdentity requesterIdentity, BrokerRequest brokerRequest);
+
+  /**
+   * Determine whether authentication is required for annotated (controller) endpoints only

Review Comment:
   Could you elaborate on this? Why do we need to mention controller endpoints in the pinot-broker module?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org