You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "goutamadwant (via GitHub)" <gi...@apache.org> on 2026/09/29 04:55:21 UTC
[PR] [Python] Validate FileBasedSink num_shards type [beam]
goutamadwant opened a new pull request, #40331:
URL: https://github.com/apache/beam/pull/40331
Fixes #25860
`FileBasedSink` currently accepts a side input for `num_shards`, then fails later while processing the pipeline.
This validates `num_shards` in the constructor and raises a clear `TypeError` when it is not an `int`. The regression test covers `AsSingleton`.
Before: the constructor accepts `AsSingleton` as `num_shards`.
After: the constructor raises `TypeError: num_shards must be an int`.
Tests:
- `python -m unittest -q apache_beam.io.filebasedsink_test` — 15 passed
- `python -m unittest -q apache_beam.io.textio_test` — 117 passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Validate FileBasedSink num_shards type [beam]
Posted by "goutamadwant (via GitHub)" <gi...@apache.org>.
goutamadwant commented on PR #40331:
URL: https://github.com/apache/beam/pull/40331#issuecomment-5884971100
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Python] Validate FileBasedSink num_shards type [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40331:
URL: https://github.com/apache/beam/pull/40331#issuecomment-5884405914
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org