[jira] [Commented] (TRINIDAD-1409) Add myfaces-builder-annotations to trinidad trunk 1.2.x, so trinidad jars could have myfaces-metadata.xml, making possible use builder plugin on trinidad sandbox

["Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/TRINIDAD-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009912#comment-13009912 ] 

Leonardo Uribe commented on TRINIDAD-1409:
------------------------------------------

I attached the final form of the solution to be committed. I did some fixes and as tests, I generated the jsp tag classes of trinidad using myfaces-builder-plugin. Curiously, the generated files are "almost" equal to the ones generated by trinidad plugin, and it is possible to use a diff tool to compare them. Functionally, the files are 100% compatible with the old ones, but the patch will not change that (only add it as a comment). With these tests, we can be sure that myfaces-builder-plugin will work fine generating trinidad components (note for the first patch, other tests like generate trinidad sandbox components were done).

The next step is commit the code on myfaces-builder-plugin, do a release, and finally commit the code in trinidad.

> Add myfaces-builder-annotations to trinidad trunk 1.2.x, so trinidad jars could have myfaces-metadata.xml, making possible use builder plugin on trinidad sandbox
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TRINIDAD-1409
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1409
>             Project: MyFaces Trinidad
>          Issue Type: Task
>          Components: Build, Components
>            Reporter: Leonardo Uribe
>            Assignee: Leonardo Uribe
>         Attachments: TRINIDAD-1409-v1-maven-faces-plugin.patch, TRINIDAD-1409-v1-trinidad.patch, TRINIDAD-1409-v2-myfaces-builder-plugin.patch, TRINIDAD-1409-v2-trinidad.patch, TRINIDAD-1409-v3-myfaces-builder-plugin.patch, TRINIDAD-1409-v3-trinidad.patch
>
>
> The first step to use myfaces-builder-plugin on trinidad is add annotations on trinidad code and try use it on trinidad-sanbox. Please note that the change proposed here does not change the generation procedure using trinidad maven-faces-plugin (includes component classes, tag classes and xml config files), just add the necessary information to generate myfaces-metadata.xml file, making it easier in the future to change the build procedure.
> To do that, the idea is change maven-faces-plugin, adding builder plugin annotations when generating component files and add the necessary information to non generated component files.
> I'll add the advance on this work here, but before commit something it is better ask trinidad community about it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira