You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by li...@apache.org on 2020/03/21 09:18:22 UTC

[servicecomb-java-chassis] branch master updated: [SCB-1787]Http 2 idleTimeoutInSeconds is not used

This is an automated email from the ASF dual-hosted git repository.

liubao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git


The following commit(s) were added to refs/heads/master by this push:
     new d99be30  [SCB-1787]Http 2 idleTimeoutInSeconds is not used
d99be30 is described below

commit d99be303e35549a40908e680241fda3a239bc90f
Author: liubao <bi...@qq.com>
AuthorDate: Fri Mar 20 12:10:06 2020 +0800

    [SCB-1787]Http 2 idleTimeoutInSeconds is not used
---
 .../servicecomb/transport/rest/client/RestTransportClient.java | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestTransportClient.java b/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestTransportClient.java
index bd23dc6..eeee42a 100644
--- a/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestTransportClient.java
+++ b/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestTransportClient.java
@@ -75,8 +75,7 @@ public class RestTransportClient {
 
   private static HttpClientOptions createHttpClientOptions(boolean http2) {
     HttpClientOptions httpClientOptions = new HttpClientOptions();
-    httpClientOptions.setIdleTimeout(TransportClientConfig.getConnectionIdleTimeoutInSeconds())
-        .setKeepAliveTimeout(TransportClientConfig.getConnectionIdleTimeoutInSeconds())
+    httpClientOptions
         .setTryUseCompression(TransportClientConfig.getConnectionCompression())
         .setMaxWaitQueueSize(TransportClientConfig.getMaxWaitQueueSize());
     if (http2) {
@@ -84,11 +83,14 @@ public class RestTransportClient {
           .setHttp2ClearTextUpgrade(false)
           .setProtocolVersion(HttpVersion.HTTP_2)
           .setHttp2MultiplexingLimit(TransportClientConfig.getHttp2MultiplexingLimit())
-          .setHttp2MaxPoolSize(TransportClientConfig.getHttp2ConnectionMaxPoolSize());
+          .setHttp2MaxPoolSize(TransportClientConfig.getHttp2ConnectionMaxPoolSize())
+          .setIdleTimeout(TransportClientConfig.getHttp2ConnectionIdleTimeoutInSeconds());
     } else {
       httpClientOptions.setMaxPoolSize(TransportClientConfig.getConnectionMaxPoolSize())
           .setKeepAlive(TransportClientConfig.getConnectionKeepAlive())
-          .setMaxHeaderSize(TransportClientConfig.getMaxHeaderSize());
+          .setMaxHeaderSize(TransportClientConfig.getMaxHeaderSize())
+          .setKeepAliveTimeout(TransportClientConfig.getConnectionIdleTimeoutInSeconds())
+          .setIdleTimeout(TransportClientConfig.getConnectionIdleTimeoutInSeconds());
     }
     VertxTLSBuilder.buildHttpClientOptions(SSL_KEY, httpClientOptions);
     return httpClientOptions;