You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Eugene Ostrovsky <eu...@gmail.com> on 2007/10/19 18:29:16 UTC

[regression][jdktools] Regression in JDKTools caused by the change in the launcher

We've got a regression in JDKTools suite:
http://people.apache.org/~mloenko/snapshot_testing/script/r585787/index.html
See: http://issues.apache.org/jira/browse/HARMONY-4979

Re: [regression][jdktools] Regression in JDKTools caused by the change in the launcher

Posted by Gregory Shimansky <gs...@apache.org>.
Pavel Rebriy wrote:
> Patch which was committed to 586759 is incorrect.
> Changes prevents JVMTI reporting execution of j.l.Thread.<init> for any
> thread not only for main.

No I disagree. The setLocallyDisabled function changes enabled status on 
thread local base. It doesn't affect other threads.

> On 20/10/2007, Gregory Shimansky <gs...@apache.org> wrote:
>> Eugene Ostrovsky wrote:
>>> The bug is fixed.
>>>
>>> Gregory,
>>> Could you please commit it ASAP.
>> I've committed your patch at 586759.
>>
>>> Thanks,
>>> Eugene.
>>>
>>> On 10/19/07, Eugene Ostrovsky <eu...@gmail.com> wrote:
>>>> We've got a regression in JDKTools suite:
>>>>
>> http://people.apache.org/~mloenko/snapshot_testing/script/r585787/index.html
>>>> See: http://issues.apache.org/jira/browse/HARMONY-4979
>>
>> --
>> Gregory
>>
>>
> 
> 


-- 
Gregory


Re: [regression][jdktools] Regression in JDKTools caused by the change in the launcher

Posted by Pavel Rebriy <pa...@gmail.com>.
Patch which was committed to 586759 is incorrect.
Changes prevents JVMTI reporting execution of j.l.Thread.<init> for any
thread not only for main.

On 20/10/2007, Gregory Shimansky <gs...@apache.org> wrote:
>
> Eugene Ostrovsky wrote:
> > The bug is fixed.
> >
> > Gregory,
> > Could you please commit it ASAP.
>
> I've committed your patch at 586759.
>
> > Thanks,
> > Eugene.
> >
> > On 10/19/07, Eugene Ostrovsky <eu...@gmail.com> wrote:
> >> We've got a regression in JDKTools suite:
> >>
> http://people.apache.org/~mloenko/snapshot_testing/script/r585787/index.html
> >> See: http://issues.apache.org/jira/browse/HARMONY-4979
>
>
> --
> Gregory
>
>


-- 
Best regards,
Pavel Rebriy

Re: [regression][jdktools] Regression in JDKTools caused by the change in the launcher

Posted by Gregory Shimansky <gs...@apache.org>.
Eugene Ostrovsky wrote:
> The bug is fixed.
> 
> Gregory,
> Could you please commit it ASAP.

I've committed your patch at 586759.

> Thanks,
> Eugene.
> 
> On 10/19/07, Eugene Ostrovsky <eu...@gmail.com> wrote:
>> We've got a regression in JDKTools suite:
>> http://people.apache.org/~mloenko/snapshot_testing/script/r585787/index.html
>> See: http://issues.apache.org/jira/browse/HARMONY-4979


-- 
Gregory


Re: [regression][jdktools] Regression in JDKTools caused by the change in the launcher

Posted by Eugene Ostrovsky <eu...@gmail.com>.
The bug is fixed.

Gregory,
Could you please commit it ASAP.

Thanks,
Eugene.

On 10/19/07, Eugene Ostrovsky <eu...@gmail.com> wrote:
> We've got a regression in JDKTools suite:
> http://people.apache.org/~mloenko/snapshot_testing/script/r585787/index.html
> See: http://issues.apache.org/jira/browse/HARMONY-4979
>