[GitHub] [airflow] josh-fell commented on a diff in pull request #23328: `GCSFileTransformOperator`: New templated fields `source_object`, `destination_object`

[GitBox <gi...@apache.org>]

josh-fell commented on code in PR #23328:
URL: https://github.com/apache/airflow/pull/23328#discussion_r860949164


##########
airflow/providers/google/cloud/operators/gcs.py:
##########
@@ -536,8 +536,10 @@ class GCSFileTransformOperator(BaseOperator):
     data from source, transform it and write the output to the local
     destination file.
 
-    :param source_bucket: The key to be retrieved from GCS. (templated)
-    :param destination_bucket: The key to be written from GCS. (templated)
+    :param source_bucket: The bucket to locate the source_object. (templated)
+    :param source_object: The key to be retrieved from GCS. (templated)
+    :param destination_bucket: The bucket to upload the key after transformation. (templated)
+    :param destination_object: The key to be written in GCS. (templated)

Review Comment:
   ```suggestion
       :param destination_bucket: The bucket to upload the key after transformation. If not provided, source_bucket will be used. (templated)
       :param destination_object: The key to be written in GCS. If not provided, source_object will be used. (templated)
   ```
   WDYT about letting users know the source_bucket/object will be used so they don't think they are required to provide either or both values?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org