You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kishore Gopalakrishna <ki...@apache.org> on 2015/03/08 22:24:44 UTC

Review Request 31835: [HELIX-572] Fixing External View update logic for bucketized resource

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31835/
-----------------------------------------------------------

Review request for helix.


Bugs: HELIX-572


Repository: helix-git


Description
-------

commit 6aae15d77ce123b7dc83bc39fccd5c7c210bd972
Author: Kishore Gopalakrishna <g....@gmail.com>
Date:   Sun Mar 8 14:20:08 2015 -0700

    [HELIX-572] Fixing External View update logic for bucketized resource

:100644 100644 169c993... 8c9fc8d... M	helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java
:100644 100644 207a318... 2b5e2bc... M	helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java
:100755 100755 82cbcf9... e869f25... M	hpost-review.sh


Diffs
-----

  helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java 169c993 
  helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java 207a318 
  hpost-review.sh 82cbcf9 

Diff: https://reviews.apache.org/r/31835/diff/


Testing
-------


Thanks,

Kishore Gopalakrishna


Re: Review Request 31835: [HELIX-572] Fixing External View update logic for bucketized resource

Posted by Kanak Biscuitwala <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31835/#review75658
-----------------------------------------------------------

Ship it!



helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java
<https://reviews.apache.org/r/31835/#comment122866>

    ```
    Assert.assertTrue(v2 > v1);
    ```


- Kanak Biscuitwala


On March 8, 2015, 2:24 p.m., Kishore Gopalakrishna wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31835/
> -----------------------------------------------------------
> 
> (Updated March 8, 2015, 2:24 p.m.)
> 
> 
> Review request for helix.
> 
> 
> Bugs: HELIX-572
> 
> 
> Repository: helix-git
> 
> 
> Description
> -------
> 
> commit 6aae15d77ce123b7dc83bc39fccd5c7c210bd972
> Author: Kishore Gopalakrishna <g....@gmail.com>
> Date:   Sun Mar 8 14:20:08 2015 -0700
> 
>     [HELIX-572] Fixing External View update logic for bucketized resource
> 
> :100644 100644 169c993... 8c9fc8d... M	helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java
> :100644 100644 207a318... 2b5e2bc... M	helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java
> :100755 100755 82cbcf9... e869f25... M	hpost-review.sh
> 
> 
> Diffs
> -----
> 
>   helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java 169c993 
>   helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java 207a318 
>   hpost-review.sh 82cbcf9 
> 
> Diff: https://reviews.apache.org/r/31835/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kishore Gopalakrishna
> 
>