[GitHub] [pinot] agavra commented on a diff in pull request #9758: [hotfix] cover non-tested data table v4 code path

[GitBox <gi...@apache.org>]

agavra commented on code in PR #9758:
URL: https://github.com/apache/pinot/pull/9758#discussion_r1016888720


##########
pinot-common/src/main/java/org/apache/pinot/common/datatable/DataTableImplV4.java:
##########
@@ -62,12 +62,23 @@ public class DataTableImplV4 extends BaseDataTable {
   protected byte[] _variableSizeDataBytes;
   protected ByteBuffer _variableSizeData;
   protected Map<String, String> _metadata;
-  private static final int VERSION = 1;
   protected int[] _columnOffsets;
   protected int _rowSizeInBytes;
 
   public DataTableImplV4() {
-    super();
+    _numRows = 0;

Review Comment:
   not sure I can tell from just reviewing the PR, what was the bug?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org